Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): patch cq backwards compatability + remove indexes #2236

Merged
merged 11 commits into from
Jul 31, 2024
Merged

feat(api): patch cq backwards compatability + remove indexes #2236

merged 11 commits into from
Jul 31, 2024

Conversation

thomasyopes
Copy link
Contributor

Ref: #1394

Description

  • Removing unnecessary indexes
  • Adding back errors on invalid state

Testing

  • Local
    • Unit test for errors
  • Staging
    • Redo original staging test for 1394 to ensure nothing changes
  • Production
    • Redo original staging test for 1394 to ensure nothing changes

Release Plan

  • ⚠️ This contains a DB migration
  • Merge this

@thomasyopes thomasyopes requested a review from leite08 June 10, 2024 21:16
@thomasyopes thomasyopes added this pull request to the merge queue Jul 31, 2024
Merged via the queue into develop with commit 6d94ef1 Jul 31, 2024
9 checks passed
@thomasyopes thomasyopes deleted the 1394-follow-up branch July 31, 2024 13:35
@thomasyopes thomasyopes mentioned this pull request Jul 31, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leite08 leite08 leite08 approved these changes

@Goncharo Goncharo Awaiting requested review from Goncharo Goncharo is a code owner

@Orta21 Orta21 Awaiting requested review from Orta21 Orta21 is a code owner

@RamilGaripov RamilGaripov Awaiting requested review from RamilGaripov RamilGaripov is a code owner

@jonahkaye jonahkaye Awaiting requested review from jonahkaye jonahkaye is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomasyopes @leite08