Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix): no relatedPersons in MR if they dont have a name #2087

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

(fix): no relatedPersons in MR if they dont have a name #2087

wants to merge 1 commit into from

Conversation

jonahkaye
Copy link
Member

Refs: #1792

Description

  • dont include relatedPerson in MR if the person doesn't have a name. Then the MR will also be considered empty and not get sent.

Testing

  • Local
    • building MRs and then testing if they get recognized as emoty
  • Staging
    • testing step 1
    • testing step 2

Release Plan

  • ⚠️ Points to master
  • Merge this

@jonahkaye jonahkaye changed the title feat(mr): updating mrs to check if related person has a name (fix): no relatedPersons in MR if they dont have a name May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goncharo Goncharo Awaiting requested review from Goncharo Goncharo will be requested when the pull request is marked ready for review Goncharo is a code owner

@leite08 leite08 Awaiting requested review from leite08 leite08 will be requested when the pull request is marked ready for review leite08 is a code owner

@Orta21 Orta21 Awaiting requested review from Orta21 Orta21 will be requested when the pull request is marked ready for review Orta21 is a code owner

@RamilGaripov RamilGaripov Awaiting requested review from RamilGaripov RamilGaripov will be requested when the pull request is marked ready for review RamilGaripov is a code owner

@thomasyopes thomasyopes Awaiting requested review from thomasyopes thomasyopes will be requested when the pull request is marked ready for review thomasyopes is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonahkaye