Add deauthentication #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orta21
commented
Dec 22, 2022
Orta21
commented
Dec 22, 2022
Orta21
commented
Dec 22, 2022
leite08
requested changes
Dec 22, 2022
Goncharo
requested changes
Dec 22, 2022
leite08
reviewed
Dec 23, 2022
api/app/src/routes/util.ts
Outdated
Comment on lines
53
to
59
| export const getProviderMapFromConnectUserOrFail = (connectedUser: ConnectedUser, provider: ProviderOptions) => { | ||
| if (!connectedUser.providerMap) throw new UnauthorizedError(); | ||
| const providerData = connectedUser.providerMap[provider]; | ||
| if (!providerData) throw new UnauthorizedError(); | ||
|
|
||
| return providerData; | ||
| } |
There was a problem hiding this comment.
Good job identifying and reusing code! 🙌
I just suggest we keep these util functions to a minimal - usually not domain-related, otherwise we can quickly have a ton of them; as well, exposing the ConnectedUser's internals adds coupling across the app.
In this case, since we need this behavior across multiple files, maybe move this function to be a command related to ConnectedUser? It could throw NotFoundError and we have the route rethrowing it as an UnauthorizedError.
Also, the function returns a Provider's data, not the map, so maybe rename to getProviderDataOrFail() or something similar?
added 2 commits
December 23, 2022 11:25
leite08
reviewed
Dec 23, 2022
api/app/src/providers/oauth2.ts
Outdated
| @@ -16,6 +16,7 @@ export const oauthUserTokenResponse = z.object({ | |||
|
|
|||
| export interface OAuth2 { | |||
| getAuthUri(state: string): Promise<string>; | |||
| revokeProviderAccess(connectedUser: ConnectedUser): Promise<void | string>; | |||
There was a problem hiding this comment.
Curious, why returning void | string? It seems we don't need to return string (maybe just add a await on Withings':
if (status === 0) {
await this.oauth.revokeLocal(connectedUser);
return;
}
Ideally we wouldn't adjust the interface's contract bc of a specific implementation.
leite08
approved these changes
Dec 23, 2022
Goncharo
requested changes
Dec 23, 2022
api/app/src/providers/withings.ts
Outdated
| @@ -100,7 +100,7 @@ export class Withings extends Provider implements OAuth2 { | |||
| const status = await this.revokeToken(client_id, client_secret, timestamp, nonce, providerData.token) | |||
|
|
|||
| if (status === 0) { | |||
| return this.oauth.revokeLocal(connectedUser); | |||
| this.oauth.revokeLocal(connectedUser); | |||
api/app/src/providers/oura.ts
Outdated
| async revokeProviderAccess(connectedUser: ConnectedUser): Promise<string> { | ||
| return this.oauth.revokeLocal(connectedUser); | ||
| async revokeProviderAccess(connectedUser: ConnectedUser): Promise<void> { | ||
| this.oauth.revokeLocal(connectedUser); |
api/app/src/providers/whoop.ts
Outdated
| async revokeProviderAccess(connectedUser: ConnectedUser) { | ||
| return this.oauth.revokeLocal(connectedUser); | ||
| async revokeProviderAccess(connectedUser: ConnectedUser): Promise<void> { | ||
| this.oauth.revokeLocal(connectedUser); |
6 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
Patch Inbound DQ Response #2
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
RELEASE 2024-03-06 #2
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 17, 2024
RELEASE 2024_05_17 #2
jonahkaye
added a commit
that referenced
this pull request
May 17, 2024
16 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 30, 2024
RELEASE 2024_05_30 #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.