Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1350 adds logs ihe #1772

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from
Draft

1350 adds logs ihe #1772

wants to merge 12 commits into from

Conversation

Orta21
Copy link
Member

@Orta21 Orta21 commented Mar 14, 2024

Ticket: #1350

Dependencies

  • Upstream: none
  • Downstream: none

Description

Add logs to mirth for more visibility

Testing

  • Local
    • See logs in the console
  • Staging
    • See logs in the console
  • Production
    • See logs in the console

Release Plan

  • Merge this

@Orta21 Orta21 marked this pull request as ready for review March 15, 2024 14:12
Copy link
Member

@leite08 leite08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will result in too many, too long, log messages:

  • too many: we get a lot of requests, so ideally we would only log the entry point of each request so we can keep track of receiving it/when;
  • too long: currently, log messages are already super long (by the nature of Java/IHE GW's setup), so I'd try and get any prefix to a minimum, maybe like IN DR, IN PD, OUT PD, etc.?

Example of existing long prefix:

INFO 2024-03-19 13:22:49.893 [Response Transformer JavaScript Task on XCA ITI-39 Processor (c7b1fb54-6dce-410c-a16a-e3ba6b6c6722), XCA Endpoint (1) < pool-1-thread-4865] ...

I like that you're fixing the conditional to log errors! A question: do you know what's the diff to .info and .error, beyond the log level? Like, are those being directed to diff places? Main concern being that we don't slow down IHE GW's Admin w/ too much log to be loaded b/c we're not filtering anymore.

Lastly, while there, can you remove the left-over log on Outbound DR dest connector, please?

@Orta21 Orta21 marked this pull request as draft March 21, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants