Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1350 Fix PD/DQ/DR piping #1665

Merged
merged 6 commits into from
Feb 26, 2024
Merged

1350 Fix PD/DQ/DR piping #1665

merged 6 commits into from
Feb 26, 2024

Conversation

leite08
Copy link
Member

@leite08 leite08 commented Feb 26, 2024 •
edited

Ticket: https://github.com/metriport/metriport-internal/issues/1350

Dependencies

Description

  • Rename/split IHE GW outbound result functions
  • Local implementation (factory) for CQ DQ/DR IHE GW result polling
  • Fix PD resp. from IHE GW, externalGatewayPatient

Testing

  • Local
    • PD works
    • DQ works
    • DR gets initiated (didn't work fully)

Release Plan

  • Merge upstream
  • Merge this
  • Update IHE GW config on staging

leite08
leite08 commented Feb 26, 2024
View reviewed changes
...ay/server/Channels/CareQuality Document Exchange - Outbound/XCA DQ ITI-38 Bulk Interface.xml
@@ -258,7 +258,7 @@ Last updated: Dec 20 2023</description>
</properties>
<exportData>
<metadata>
<enabled>false</enabled>
<enabled>true</enabled>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-enable channel

leite08
leite08 commented Feb 26, 2024
View reviewed changes
...ihe-gateway/server/Channels/CareQuality Document Exchange - Outbound/XCPD Bulk Interface.xml
@@ -250,7 +250,7 @@ Last updated: Dec 08 2023</description>
</properties>
<exportData>
<metadata>
<enabled>false</enabled>
<enabled>true</enabled>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-enable channel

leite08
leite08 commented Feb 26, 2024
View reviewed changes
...ay/server/Channels/CareQuality Document Exchange - Outbound/XCA DR ITI-39 Bulk Interface.xml
@@ -253,7 +253,7 @@ Last updated: Dec 05 2023</description>
</properties>
<exportData>
<metadata>
<enabled>false</enabled>
<enabled>true</enabled>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-enable channel

leite08
leite08 commented Feb 26, 2024
View reviewed changes
...-gateway/server/Channels/CareQuality Document Exchange - Outbound/XCA - DR App Interface.xml Outdated

<contentType>text/plain</contentType>

<contentType>application/json</contentType>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update content type

leite08
leite08 commented Feb 26, 2024
View reviewed changes
...-gateway/server/Channels/CareQuality Document Exchange - Outbound/XCA - DQ App Interface.xml Outdated

<contentType>text/plain</contentType>

<contentType>application/json</contentType>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update content type

@leite08 leite08 changed the title 1350 Fix PD/DQ 1350 Fix PD/DQ/DR piping Feb 26, 2024
@leite08 leite08 marked this pull request as ready for review February 26, 2024 07:41
@leite08 leite08 changed the base branch from develop to 1377-move-ihe-gw-infra_7 February 26, 2024 07:42
Goncharo
Goncharo approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@Goncharo Goncharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM - one Q about inbount DR

packages/infra/lib/ihe-stack/ihe-gateway.ts Show resolved Hide resolved
Base automatically changed from 1377-move-ihe-gw-infra_7 to develop February 26, 2024 17:08
@leite08 leite08 merged commit 9d5294c into develop Feb 26, 2024
9 checks passed
@leite08 leite08 deleted the 1350-fix-PD branch February 26, 2024 17:15
@leite08 leite08 mentioned this pull request Feb 26, 2024
Merged
16 tasks
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.63.0-develop.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.64.0-develop.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.64.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goncharo Goncharo Goncharo approved these changes

@Orta21 Orta21 Orta21 approved these changes

@RamilGaripov RamilGaripov Awaiting requested review from RamilGaripov RamilGaripov is a code owner

Assignees
No one assigned
Labels
released on @develop released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leite08 @Goncharo @Orta21