1350 Add CQ PD to patient update #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leite08
requested review from
Goncharo,
Orta21 and
RamilGaripov
as code owners
leite08
commented
Feb 24, 2024
Comment on lines
+58
to
+63
| const addressWithCoordinates = await addCoordinatesToAddresses({ | ||
| addresses: patientUpdate.address, | ||
| patient: patientUpdate, | ||
| reportRelevance: true, | ||
| }); | ||
| if (addressWithCoordinates) patientUpdate.address = addressWithCoordinates; |
There was a problem hiding this comment.
There was no reason to have this inside the DB tx, moved to improve performance of the platform as a whole.
leite08
commented
Feb 24, 2024
Comment on lines
-130
to
-138
| // temp solution until we migrate to FHIR | ||
| const fhirPatient = toFHIR(updatedPatient); | ||
| await upsertPatientToFHIRServer(updatedPatient.cxId, fhirPatient); | ||
|
|
||
| // TODO: #393 declarative, event-based integration | ||
| // Intentionally asynchronous - it takes too long to perform | ||
| cwCommands.patient | ||
| .update(updatedPatient, facilityId) | ||
| .catch(processAsyncError(`cw.patient.update`)); |
There was a problem hiding this comment.
Moved to inside updatePatient so the command does all its needed when we update a patient
4 tasks
leite08
force-pushed
the
1350-trigger-dq-on-patient-udpate
branch
from
9768841
to
32b6496
Compare
- one flag
|
🎉 This PR is included in version 5.63.0-develop.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.64.0-develop.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.64.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. metriport/metriport-internal#1350
Dependencies
none
Description
Testing
Release Plan