Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ihe): fix mirth dr channel to send message to api #1656

Merged
merged 2 commits into from
Feb 24, 2024

Conversation

Orta21
Copy link
Member

@Orta21 Orta21 commented Feb 24, 2024

refs. metriport/metriport-internal#1377

Dependencies

n/a

Description

Route mirth dr response to the api

Testing

  • Local
    • made request to mirth and received response from in api

Release Plan

  • Merge this

Copy link
Member

@Goncharo Goncharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conditional approval based on addressing comments

<description>XCA App Interface channel
- forwards a single request back to the calling app or DB

Last updated: Nov 30 2023</description>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the Last updated set by us manually? If so, let's just remove this? We won't remember to always keep this up to date


const baseAddress = globalMap.get("API_BASE_ADDRESS");
if (!baseAddress) {
logger.error("XCPD App Interface: Failed start, missing API_BASE_ADDRESS");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XCA DR Interface

@Orta21 Orta21 merged commit 7ffaa3f into develop Feb 24, 2024
3 checks passed
@Orta21 Orta21 deleted the 1377-mirth-dr-api branch February 24, 2024 18:12
Copy link

🎉 This PR is included in version 5.63.0-develop.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 5.64.0-develop.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 5.64.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants