Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api-sdk): updated cq directory handling code #1575

Merged
merged 27 commits into from
Feb 23, 2024
Merged

fix(api-sdk): updated cq directory handling code #1575

merged 27 commits into from
Feb 23, 2024

Conversation

RamilGaripov
Copy link
Contributor

@RamilGaripov RamilGaripov commented Feb 5, 2024 •
edited
Loading

refs. metriport/metriport-internal#1350

Dependencies

Description

  • Updated the CQDirectoryModel to include 2 new fields: gateway (to indicate whether an org is a gateway or not, and managing_organization
  • Added migration files to update the table
  • Improved OID extraction regex
  • Added code to post-process CQ directory rebuilding to find all gateways in the directory
  • Added CQ XCPD prep logic that prevents requests to CW

Testing

  • Local
    • Local testing of both staging and prod directories

Release Plan

  • ⚠️ This contains a DB migration
  • Upstream dependencies are met/released
  • Release NPM packages
  • Merge this
  • Action on staging and production:
    • rebuild cq directory on staging
    • rebuild cq directory on prod

@RamilGaripov
fix(api-sdk): updated cq directory handling code
b880f13 
refs. metriport/metriport-internal#1350
@RamilGaripov
fix(api-sdk): removed cw from cq xcpd
0309437 
refs. metriport/metriport-internal#1350
@RamilGaripov
fix(api-sdk): merged develop and fixed some conflicts
d16a847 
refs. metriport/metriport-internal#1350
@RamilGaripov
fix(api-sdk): improved oid normalization
504d00d 
refs. metriport/metriport-internal#1350
@RamilGaripov
chore(release): publish
ff96bf1 
Ref: #000

 - [email protected]
 - @metriport/[email protected]
 - @metriport/[email protected]
 - @metriport/[email protected]
 - @metriport/[email protected]
 - @metriport/[email protected]
 - @metriport/[email protected]
 - @metriport/[email protected]
 - @metriport/[email protected]
 - [email protected]
 - @metriport/[email protected]
 - @metriport/[email protected]
 - [email protected]
 - [email protected]
@RamilGaripov
chore(release): publish
de5c05c 
Ref: #000

 - @metriport/[email protected]
 - @metriport/[email protected]
 - @metriport/[email protected]
 - @metriport/[email protected]
 - [email protected]
@RamilGaripov
fix(api-sdk): fixed a bug in tests
7dda4f2 
refs. metriport/metriport-internal#1350
@RamilGaripov RamilGaripov marked this pull request as ready for review February 8, 2024 04:53
leite08
leite08 reviewed Feb 12, 2024
View reviewed changes
packages/api/src/external/carequality/command/cq-directory/cq-gateways.ts Outdated Show resolved Hide resolved
packages/api/src/external/carequality/patient.ts Outdated Show resolved Hide resolved
packages/api/src/external/carequality/command/cq-directory/search-cq-directory.ts Outdated Show resolved Hide resolved
packages/api/src/external/carequality/command/cq-directory/create-cq-directory-entry.ts Outdated Show resolved Hide resolved
packages/api/src/external/carequality/command/cq-directory/cq-gateways.ts Show resolved Hide resolved
packages/carequality-sdk/src/models/organization.ts Outdated Show resolved Hide resolved
packages/infra/config/env-config.ts Outdated Show resolved Hide resolved
packages/shared/src/common/normalize-oid.ts Outdated Show resolved Hide resolved
packages/shared/src/common/normalize-oid.ts Outdated Show resolved Hide resolved
packages/shared/src/common/normalize-oid.ts Show resolved Hide resolved
@leite08
Copy link
Member

leite08 commented Feb 12, 2024

There's no script to update the DB's existing entries b/c we're assuming it will be re-built, right?

jonahkaye added a commit that referenced this pull request Feb 13, 2024
@jonahkaye
feat(api): unit testing for regex oids
7531ca3 
Refs: #1575
jonahkaye
jonahkaye approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@jonahkaye jonahkaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: regex and unit testing LGTM

leite08
leite08 requested changes Feb 19, 2024
View reviewed changes
Copy link
Member

@leite08 leite08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please check unanswered comments from prior review

packages/carequality-sdk/src/client/carequality.ts Outdated Show resolved Hide resolved
packages/carequality-sdk/src/client/carequality.ts Outdated Show resolved Hide resolved
packages/carequality-sdk/src/client/carequality.ts Show resolved Hide resolved
packages/shared/src/common/__tests__/normalize-oid.test.ts Outdated Show resolved Hide resolved
packages/api/src/sequelize/migrations/2024-02-05_00_alter-cq-directory-add-gateway.ts Outdated Show resolved Hide resolved
packages/api/src/external/carequality/command/cq-directory/search-cq-directory.ts Outdated Show resolved Hide resolved
packages/api/src/external/carequality/command/cq-directory/cq-gateways.ts Outdated Show resolved Hide resolved
@RamilGaripov RamilGaripov marked this pull request as draft February 22, 2024 16:21
@RamilGaripov RamilGaripov marked this pull request as ready for review February 22, 2024 18:04
leite08
leite08 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@leite08 leite08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved considering no changes on how we deal w/ CQ gateways.

Goncharo
Goncharo approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@Goncharo Goncharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@RamilGaripov RamilGaripov merged commit 1516dc0 into develop Feb 23, 2024
29 checks passed
@RamilGaripov RamilGaripov deleted the 1350-cq-directory-upd branch February 23, 2024 19:40
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.63.0-develop.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@RamilGaripov RamilGaripov mentioned this pull request Feb 26, 2024
Merged
16 tasks
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.64.0-develop.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.64.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leite08 leite08 leite08 approved these changes

@Goncharo Goncharo Goncharo approved these changes

@jonahkaye jonahkaye jonahkaye approved these changes

@Orta21 Orta21 Awaiting requested review from Orta21 Orta21 is a code owner

Assignees
No one assigned
Labels
released on @develop released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RamilGaripov @leite08 @Goncharo @jonahkaye