Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to DQ and DR PRs #1528

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
+187 −141
Draft

Improvements to DQ and DR PRs #1528

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fdb3373
feat(cq): fixing nits on dq pr
jonahkaye Jan 26, 2024
ca03831
feat(cq): nits on dr pr
jonahkaye Jan 28, 2024
f7038d3
feat(cq): tested changes local
jonahkaye Jan 28, 2024
c305351
feat(cq): better naming a function and better log
jonahkaye Jan 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
feat(cq): better naming a function and better log 
Refs: #1379
  • Loading branch information
@jonahkaye
jonahkaye committed Jan 28, 2024
commit c3053516902e5231eec1060ef2d87dc182e6c4ab
2 changes: 1 addition & 1 deletion packages/core/src/external/aws/lambda-logic/document-uploader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export async function documentUploaderHandler(
);

if (!exists) {
const message = "Failed to get file info from the copied file";
const message = `Failed to get file info from the copied file for cxId: ${cxId}, patientId: ${patientId}, docId: ${docId}`;
console.log(message);
throw new MetriportError(message, null, { destinationBucket, destinationKey });
}
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/external/aws/s3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ export class S3Utils {
}
}

async retrieveDocumentContentFromS3(
async retrieveDocumentsContentFromS3(
bucketName: string,
prefix: string,
endsWith: string
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/external/carequality/dq/validating-dq.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export async function validateDQ(payload: DocumentQueryReqFromExternalGW): Promi
const s3Utils = new S3Utils(region);
const prefix = `${cxId}/${id}/uploads/`;
const endsWith = "_metadata.xml";
const documentContents = await s3Utils.retrieveDocumentContentFromS3(
const documentContents = await s3Utils.retrieveDocumentsContentFromS3(
medicalDocumentsBucketName,
prefix,
endsWith
Expand Down
Loading