Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1392 id null flavors #1377

Merged
merged 4 commits into from
Dec 30, 2023
Merged

1392 id null flavors #1377

merged 4 commits into from
Dec 30, 2023

Conversation

Orta21
Copy link
Member

@Orta21 Orta21 commented Dec 30, 2023

Ref. metriport/metriport-internal#1392

Ticket: 1392

Description

Fix bug in prod with null flavor in xml

Testing

  • Production
    • Manually validate CDAS
    • Validate at scale

Release Plan

  • ⚠️ Points to master
  • Merge this

Copy link
Member

@Goncharo Goncharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Orta21 Orta21 added this pull request to the merge queue Dec 30, 2023
Merged via the queue into master with commit 79d2449 Dec 30, 2023
5 checks passed
@Orta21 Orta21 deleted the 1392-id-null-flavors branch December 30, 2023 02:12
Copy link

🎉 This PR is included in version 5.34.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

jonahkaye added a commit that referenced this pull request Jan 18, 2024
@jonahkaye jonahkaye mentioned this pull request Jan 18, 2024
6 tasks
jonahkaye added a commit that referenced this pull request Jan 19, 2024
jonahkaye added a commit that referenced this pull request Jan 19, 2024
jonahkaye added a commit that referenced this pull request Jan 19, 2024
jonahkaye added a commit that referenced this pull request Jan 19, 2024
jonahkaye added a commit that referenced this pull request Jan 26, 2024
jonahkaye added a commit that referenced this pull request Jan 28, 2024
jonahkaye added a commit that referenced this pull request Jan 28, 2024
jonahkaye added a commit that referenced this pull request Jan 29, 2024
jonahkaye added a commit that referenced this pull request Jan 29, 2024
jonahkaye added a commit that referenced this pull request Jan 29, 2024
jonahkaye added a commit that referenced this pull request Feb 1, 2024
jonahkaye added a commit that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants