ihe stack 3/4 - DQ Response #1362
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Refs: #1379
Refs: #1379
| const { size, contentType, eTag } = await s3Utils.getFileInfoFromS3( | ||
| destinationKey, | ||
| destinationBucket | ||
| ); |
There was a problem hiding this comment.
eTag is md5 hash of document. At documents greater than 5gb this is not exactly true but good enough for now.
| @@ -62,7 +62,7 @@ export type DocumentQueryRequestIncoming = z.infer<typeof documentQueryRequestIn | |||
|
|
|||
| export type DocumentQueryResponseOutgoing = | |||
| | (BaseResponse & { | |||
| documentReference: DocumentReference[]; | |||
| extrinsicObjectXmls: string[]; | |||
| }) | |||
|
🎉 This PR is included in version 5.49.0-develop.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
| const uniqueId = createPatientUniqueId(patient.cxId, patient.id); | ||
| const updatedPatient: Patient = { | ||
| ...patient, | ||
| id: uniqueId, |
There was a problem hiding this comment.
I think we should store uniqueId on a property other than id... this will be super confusing when we try to debug and/or reuse this endpoint (id is the patient ID, not something else). If the lambda needs to convert it to something else when responding to CQ, that's cool, but that's a lambda's job IMO.
There was a problem hiding this comment.
the issue is we the docIds needs to be made of the cxId and patientId in order to support the flow we have with retrieving metadata files from s3. PatientDTO in api-sdk understandably does not return cxID, so the best place to do this is here. I think this is not worth changing since odds are we will move domain to core before we reuse this endpoint for anything else, and then we wont need the endpoint at all since the lambda can read from db directly and all this code will be refactored.
I can't think of any upcoming situations where we will resuse this endpoint in the near future I think this is the best solution for now
|
🎉 This PR is included in version 5.49.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Ticket: #1379
Dependencies
Description
Testing
Release Plan