Merge pull request #2207 from metriport/1669-inbound-stats

1669 inbound stats
metriport · Jun 5, 2024 · ca9903f · ca9903f
2 parents cdd300c + a2f0a78
commit ca9903f
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 9 deletions.
diff --git a/packages/core/src/external/analytics/posthog.ts b/packages/core/src/external/analytics/posthog.ts
@@ -18,7 +18,7 @@ export interface EventMessageV1 extends IdentifyMessageV1 {
 
 const defaultPostHogApiKey = Config.getPostHogApiKey();
 
-export const analytics = (params: EventMessageV1, postApiKey?: string) => {
+export function analytics(params: EventMessageV1, postApiKey?: string): PostHog | void {
  const apiKey = postApiKey ?? defaultPostHogApiKey;
  if (!apiKey) return;
 
@@ -34,7 +34,19 @@ export const analytics = (params: EventMessageV1, postApiKey?: string) => {
  };
 
  posthog.capture(params);
-};
+
+ return posthog;
+}
+
+export async function analyticsAsync(params: EventMessageV1, postApiKey?: string) {
+ const posthog = analytics(params, postApiKey);
+
+ if (!posthog) return;
+
+ // Needed to send requests to PostHog in lambda
+ // https://posthog.com/docs/libraries/node#using-in-a-short-lived-process-like-aws-lambda
+ await posthog.shutdown();
+}
 
 export enum EventTypes {
  query = "query",

diff --git a/packages/lambdas/src/ihe-inbound-document-query.ts b/packages/lambdas/src/ihe-inbound-document-query.ts
@@ -2,7 +2,7 @@ import { inboundDocumentQueryReqSchema } from "@metriport/ihe-gateway-sdk";
 import * as Sentry from "@sentry/serverless";
 import { getSecretValue } from "@metriport/core/external/aws/secret-manager";
 import { processInboundDocumentQuery } from "@metriport/core/external/carequality/dq/process-inbound-dq";
-import { analytics, EventTypes } from "@metriport/core/external/analytics/posthog";
+import { analyticsAsync, EventTypes } from "@metriport/core/external/analytics/posthog";
 import { getEnvVarOrFail, getEnvVar } from "@metriport/core/util/env-var";
 
 const apiUrl = getEnvVarOrFail("API_URL");
@@ -23,8 +23,7 @@ export const handler = Sentry.AWSLambda.wrapHandler(async (event: string) => {
  const postHogApiKey = await getSecretValue(postHogSecretName, region);
 
  if (postHogApiKey && engineeringCxId) {
- result.externalGatewayPatient?.system;
- analytics(
+ await analyticsAsync(
  {
  distinctId: engineeringCxId,
  event: EventTypes.inboundDocumentQuery,

diff --git a/packages/lambdas/src/ihe-inbound-document-retrieval.ts b/packages/lambdas/src/ihe-inbound-document-retrieval.ts
@@ -3,7 +3,7 @@ import * as Sentry from "@sentry/serverless";
 import { getSecretValue } from "@metriport/core/external/aws/secret-manager";
 import { getEnvVar, getEnvVarOrFail } from "@metriport/core/util/env-var";
 import { processInboundDocumentRetrieval } from "@metriport/core/external/carequality/dr/process-inbound-dr";
-import { analytics, EventTypes } from "@metriport/core/external/analytics/posthog";
+import { analyticsAsync, EventTypes } from "@metriport/core/external/analytics/posthog";
 
 const postHogSecretName = getEnvVar("POST_HOG_API_KEY_SECRET");
 const engineeringCxId = getEnvVar("ENGINEERING_CX_ID");
@@ -21,7 +21,7 @@ export const handler = Sentry.AWSLambda.wrapHandler(async (event: string) => {
  const postHogApiKey = await getSecretValue(postHogSecretName, region);
 
  if (postHogApiKey && engineeringCxId) {
- analytics(
+ await analyticsAsync(
  {
  distinctId: engineeringCxId,
  event: EventTypes.inboundDocumentRetrieval,

diff --git a/packages/lambdas/src/ihe-inbound-patient-discovery.ts b/packages/lambdas/src/ihe-inbound-patient-discovery.ts
@@ -4,7 +4,7 @@ import { MPIMetriportAPI } from "@metriport/core/mpi/patient-mpi-metriport-api";
 import { getEnvVarOrFail, getEnvVar } from "@metriport/core/util/env-var";
 import { getSecretValue } from "@metriport/core/external/aws/secret-manager";
 import { inboundPatientDiscoveryReqSchema } from "@metriport/ihe-gateway-sdk";
-import { analytics, EventTypes } from "@metriport/core/external/analytics/posthog";
+import { analyticsAsync, EventTypes } from "@metriport/core/external/analytics/posthog";
 import * as Sentry from "@sentry/serverless";
 
 const apiUrl = getEnvVarOrFail("API_URL");
@@ -27,7 +27,7 @@ export const handler = Sentry.AWSLambda.wrapHandler(async (event: string) => {
  const postHogApiKey = await getSecretValue(postHogSecretName, region);
 
  if (postHogApiKey && engineeringCxId) {
- analytics(
+ await analyticsAsync(
  {
  distinctId: engineeringCxId,
  event: EventTypes.inboundPatientDiscovery,