Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct tiered structure of the headings on the sidebar of the new theme. #77

Merged
merged 1 commit into from
May 31, 2018

Conversation

abernix
Copy link
Contributor

@abernix abernix commented May 31, 2018

No description provided.


li {
@indent: 15px;
//padding-left: @indent;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This previous padding-left was pretty important, in that it maintained the nested structure which was implied by the "unordered lists" (<ul>s). This has been re-created by use of the nested li classing shown above and to the right.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thank goodness, I didn't remove this commented section just yet. Great job @peggy @abernix

@abernix abernix merged commit e7ac1cf into master May 31, 2018
@abernix abernix deleted the abernix/fix-new-theme-sidebar-spacing branch May 31, 2018 20:49
@abernix
Copy link
Contributor Author

abernix commented May 31, 2018

I can't not give a big enough shoutout to @peggyrayzis for going through this with me!

abernix added a commit that referenced this pull request May 31, 2018
Oversight in #77, due to not checking every section more carefully.
abernix added a commit that referenced this pull request May 31, 2018
Oversight in #77, due to not checking every section more carefully.
abernix pushed a commit to apollographql/apollo-ios that referenced this pull request May 31, 2018
This Pull Request updates dependency [meteor-theme-hexo](https://github.com/meteor/meteor-theme-hexo) from `v1.0.10` to `v1.0.13`



<details>
<summary>Release Notes</summary>

### [`v1.0.13`](https://github.com/meteor/meteor-theme-hexo/blob/master/CHANGELOG.md#v1013)
[Compare Source](meteor/meteor-theme-hexo@v1.0.12...v1.0.13)
* Align headings with tiered structure content.
  [PR #&#8203;78](`meteor/meteor-theme-hexo#78)

---

### [`v1.0.12`](https://github.com/meteor/meteor-theme-hexo/blob/master/CHANGELOG.md#v1012)
[Compare Source](meteor/meteor-theme-hexo@v1.0.11...v1.0.12)
* Fix the tiered structure of the sidebar items to maintain content nesting!
  [PR #&#8203;77](`meteor/meteor-theme-hexo#77)

---

### [`v1.0.11`](https://github.com/meteor/meteor-theme-hexo/blob/master/CHANGELOG.md#v1011)
[Compare Source](meteor/meteor-theme-hexo@2b6e168...v1.0.11)
* Update theme with new look for Apollo.  The Meteor theme is mostly untouched
  but there have been some small changes in it as well.
  [PR #&#8203;71](`meteor/meteor-theme-hexo#71)

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
abernix pushed a commit to apollographql/apollo-kotlin that referenced this pull request May 31, 2018
This Pull Request updates dependency [meteor-theme-hexo](https://github.com/meteor/meteor-theme-hexo) from `v1.0.10` to `v1.0.13`



<details>
<summary>Release Notes</summary>

### [`v1.0.13`](https://github.com/meteor/meteor-theme-hexo/blob/master/CHANGELOG.md#v1013)
[Compare Source](meteor/meteor-theme-hexo@v1.0.12...v1.0.13)
* Align headings with tiered structure content.
  [PR #&#8203;78](`meteor/meteor-theme-hexo#78)

---

### [`v1.0.12`](https://github.com/meteor/meteor-theme-hexo/blob/master/CHANGELOG.md#v1012)
[Compare Source](meteor/meteor-theme-hexo@v1.0.11...v1.0.12)
* Fix the tiered structure of the sidebar items to maintain content nesting!
  [PR #&#8203;77](`meteor/meteor-theme-hexo#77)

---

### [`v1.0.11`](https://github.com/meteor/meteor-theme-hexo/blob/master/CHANGELOG.md#v1011)
[Compare Source](meteor/meteor-theme-hexo@2b6e168...v1.0.11)
* Update theme with new look for Apollo.  The Meteor theme is mostly untouched
  but there have been some small changes in it as well.
  [PR #&#8203;71](`meteor/meteor-theme-hexo#71)

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
abernix pushed a commit to ardatan/graphql-tools that referenced this pull request May 31, 2018
This Pull Request updates dependency [meteor-theme-hexo](https://github.com/meteor/meteor-theme-hexo) from `v1.0.11` to `v1.0.13`



<details>
<summary>Release Notes</summary>

### [`v1.0.13`](https://github.com/meteor/meteor-theme-hexo/blob/master/CHANGELOG.md#v1013)
[Compare Source](meteor/meteor-theme-hexo@v1.0.12...v1.0.13)
* Align headings with tiered structure content.
  [PR #&#8203;78](`meteor/meteor-theme-hexo#78)

---

### [`v1.0.12`](https://github.com/meteor/meteor-theme-hexo/blob/master/CHANGELOG.md#v1012)
[Compare Source](meteor/meteor-theme-hexo@v1.0.11...v1.0.12)
* Fix the tiered structure of the sidebar items to maintain content nesting!
  [PR #&#8203;77](`meteor/meteor-theme-hexo#77)

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants