Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add H2 support #33

Closed
wants to merge 123 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
123 commits
Select commit Hold shift + click to select a range
d8d3c94
docs(Dispatcher): adjust documentation for reset flag (#1852)
metcoder95 Jan 11, 2023
e926fa4
Fix broken interceptor test (#1853)
mcollina Jan 11, 2023
8c90b01
Bumped v5.15.0
mcollina Jan 11, 2023
d5af7dd
fix(websocket): simplify typedarray copying (#1854)
KhafraDev Jan 12, 2023
f9aa0f1
fix: wpts on node v18.13.0+ (#1859)
KhafraDev Jan 17, 2023
61246a5
perf: allow keep alive for HEAD requests (#1858)
ronag Jan 17, 2023
16c4128
fix: flaky abort test (#1863)
KhafraDev Jan 18, 2023
c9d4a6b
fix: flaky abort test
ronag Jan 19, 2023
9d5f231
5.15.1
ronag Jan 19, 2023
2d2512c
fix: don't load websockets w/o crypto support (#1868)
KhafraDev Jan 19, 2023
22d2f70
fix: don't include websockets in node bundle (#1869)
merceyz Jan 19, 2023
f61a902
fix: don't set socket on client before init
ronag Jan 20, 2023
d6ba9e5
Fix fetch parameters not being applied correctly (#1870)
xconverge Jan 20, 2023
5883598
fix: typo in contributing.md (#1874)
debadree25 Jan 20, 2023
1813408
chore(performance#38): Performance improvements (#1871)
metcoder95 Jan 20, 2023
d7602f6
perf(util): improve isFormDataLike checks (#1875)
mateonunez Jan 21, 2023
9457c97
5.15.2
ronag Jan 22, 2023
69ede10
Add feature to specify custom headers for proxies (#1877)
Sebmaster Jan 22, 2023
d0a99c2
fix: don't swallow llhttp loading error
ronag Jan 23, 2023
81b1521
5.16.0
ronag Jan 23, 2023
bdb1d08
fix(wpts): Blob is a global getter in >=v19.x.x (#1880)
KhafraDev Jan 24, 2023
f02ab5b
doc: fix anchor links dispatcher.stream (#1881)
RafaelGSS Jan 25, 2023
25a8aac
wpt: make runner more resilient (#1884)
KhafraDev Jan 26, 2023
47f574d
Make test pass in v19.x (#1879)
mcollina Jan 26, 2023
196c4da
remove timeout-minutes in github action
mcollina Jan 27, 2023
a9dabd5
Correct the type of DispatchOptions["headers"] (#1896)
pan93412 Jan 29, 2023
67e9796
perf(content-type parser): faster string collector (#1894)
KhafraDev Jan 29, 2023
f4693d6
feat: expose content-type parser (#1895)
KhafraDev Jan 29, 2023
0c75102
Update DispatchOptions type (#1889)
xconverge Jan 29, 2023
055780a
fix: update error type definitions (#1888)
rafaelcr Jan 30, 2023
db0b5ca
fix: ensure connection header is a string (#1900)
ronag Feb 1, 2023
2b260c9
fix: throw if invalid content-type header (#1901)
ronag Feb 1, 2023
0986381
fix(fetch): use semicolon for Cookie header delimiter (#1906)
KhafraDev Feb 3, 2023
208f7cf
perf: use FastBuffer (#1907)
ronag Feb 4, 2023
16b7a68
5.17.0
ronag Feb 4, 2023
d2be675
fix: bad buffer slice
ronag Feb 4, 2023
ce6a53b
5.17.1
ronag Feb 4, 2023
b4c0e5a
Add ability to set TCP keepalive (#1904)
xconverge Feb 4, 2023
b06f19f
use faster timers (#1908)
ronag Feb 5, 2023
3bc7b4c
fix: ensure header value is a string (#1899)
ronag Feb 6, 2023
6641f93
fix: flaky test
ronag Feb 6, 2023
9dceb21
5.18.0
ronag Feb 6, 2023
7827031
fix(fetch): raise AbortSignal max event listeners (#1910)
KhafraDev Feb 7, 2023
c0ba75f
fix: content-disposition header parsing (#1911)
climba03003 Feb 8, 2023
0a59535
fix: remove test (#1916)
KhafraDev Feb 8, 2023
ba5ef44
feat: add Headers.prototype.getSetCookie (#1915)
KhafraDev Feb 8, 2023
87fa734
fix(headers): clone getSetCookie list & add getSetCookie type (#1917)
KhafraDev Feb 9, 2023
e155c6d
doc(mock): update out-of-date reply documentation (#1913)
p9f Feb 10, 2023
aebb232
fix(types): add missing keepAlive params (#1918)
SkeLLLa Feb 13, 2023
f7c6c6a
Make the fetch() abort test pass locally, on Linux and Mac, Node 18 a…
mcollina Feb 13, 2023
f5c89e5
Bumped v5.19.0
mcollina Feb 13, 2023
a2eff05
Merge pull request from GHSA-5r9g-qh6m-jxff
ronag Feb 13, 2023
f2324e5
Merge pull request from GHSA-r6ch-mqf9-qc9w
Trott Feb 13, 2023
6c32c0f
lint fixes
mcollina Feb 13, 2023
984d53b
Bumped v5.19.1
mcollina Feb 13, 2023
2971280
perf: improve cookie parsing performance (#1931)
KhafraDev Feb 15, 2023
f73ec63
fix: disable websocket wpts in ci :( (#1932)
KhafraDev Feb 15, 2023
c2387e8
fix: Allow “undefined“ as value in headers (#1929)
pan93412 Feb 15, 2023
eae6807
feat: Support autoSelectFamily when connecting. (#1914)
ShogunPanda Feb 15, 2023
8b8bfa7
fix: copy cookies when cloning haders (#1936)
KhafraDev Feb 16, 2023
eaf4dc9
test: more logs in wpt runner (#1933)
KhafraDev Feb 16, 2023
30dafe3
feat: change headersTimeout and bodyTimeout to 300s (#1937)
kyrylkov Feb 17, 2023
28b9dea
Bumped v5.20.0
mcollina Feb 18, 2023
d8d9a96
Create scorecard.yml (#1942)
RafaelGSS Feb 20, 2023
d04ec2b
ci: timeout CI jobs after 15 minutes (#1946)
dominykas Feb 21, 2023
5851019
test(wpt): respect variants (#1951)
panva Feb 21, 2023
ab494d2
fix: improve isFormDataLike compat (#1953)
ronag Feb 21, 2023
bc8e2b8
fix: flaky fetch tests (#1956)
KhafraDev Feb 22, 2023
474f54f
test(wpt): include all testing files (#1954)
KhafraDev Feb 22, 2023
0beedf9
fix: remove unneeded fetch tests (#1960)
KhafraDev Feb 22, 2023
e959307
fix: use normal timers for delays < 1s (#1961)
ronag Feb 22, 2023
b13312d
perf: optimize happy path (#1955)
anonrig Feb 22, 2023
178a97c
fix: 🐛 add URL upstream variations in BalancedPool types (#1966)
jimmy-guzman Feb 22, 2023
0faf03e
test(wpt): handle uncaught exceptions (#1965)
KhafraDev Feb 23, 2023
324f3e3
Fix failing wpts (#1967)
KhafraDev Feb 23, 2023
236df29
test(wpt): add results to an existing WPT Report (#1944)
panva Feb 23, 2023
e461407
fix: strengthen isStream condition checking (#1969)
debadree25 Feb 23, 2023
987d23d
fix: implement basic policy container (#1970)
KhafraDev Feb 24, 2023
06f77a9
TypeScript type fixes, for #1949 (#1968)
joshxyzhimself Feb 24, 2023
49c6b48
websocket: separate connection logic from websocket (#1973)
KhafraDev Feb 26, 2023
97ab273
README: h3 not showing ### as a header (#1975)
hilleer Feb 27, 2023
2f463fc
wptrunner: expose gc (#1974)
KhafraDev Feb 27, 2023
41aab94
perf: cork socket before writing (#1982)
ronag Mar 2, 2023
4885b11
fix: fast timers and event loop lag (#1977)
ronag Mar 3, 2023
71c3605
fix: correctly calculate resource timing duration (#1988)
amilajack Mar 4, 2023
3606c35
wpt: update tests (#1984)
KhafraDev Mar 4, 2023
a0afde8
fix: undici stream throwOnError (#1995)
dancastillo Mar 10, 2023
babed9c
fix: remove unnecessary WeakRef (#2000)
ronag Mar 10, 2023
0d2f4f1
Add missing import (#1997)
blazingzephyr Mar 10, 2023
65eea9b
feat: add abort signal to body.dump() (#1993)
debadree25 Mar 10, 2023
06c6488
fix(fetch): third party abortcontrollers throwing errors (#2002)
KhafraDev Mar 11, 2023
1bbcfa2
Improve ProxyAgent example with autentication (#2004)
egmen Mar 13, 2023
90d45fa
Add clientFactory option to ProxyAgent (#2003)
andrewfecenko Mar 13, 2023
98b63b2
Bumped v5.21.0
mcollina Mar 13, 2023
f04f9fa
Fix typo in kPipelining symbol (#2005)
andrewfecenko Mar 13, 2023
a64eb26
fix(fetch): remove `undefined` error cause (#2006)
aduh95 Mar 13, 2023
ebf0b45
chore(deps-dev): bump tsd from 0.25.0 to 0.27.0 (#2007)
dependabot[bot] Mar 13, 2023
6ec8f4e
build(deps-dev): bump wait-on from 6.0.1 to 7.0.1 (#1820)
dependabot[bot] Mar 13, 2023
4e1e0d0
fix(wpt): set global META_TITLE for the runner (#2008)
panva Mar 14, 2023
6fd7477
fix: issue 2009 (#2013)
KhafraDev Mar 17, 2023
7276126
build(deps-dev): bump typescript from 4.9.5 to 5.0.2 (#2018)
dependabot[bot] Mar 20, 2023
e6fc80f
added descriptive error messages for URL parser (#2016)
RishabhKodes Mar 22, 2023
f0271d4
fix(fetch): remove content-length header on redirect (#2022)
KhafraDev Mar 25, 2023
a9ef509
fix(fetch): remove assertion on request.body.source on redirect (#202…
macno Mar 28, 2023
dc8d111
fix: skip failing test in node >= v19.8 (#2034)
KhafraDev Mar 29, 2023
9013a23
fetch: treat content-encoding as case-insensitive & remove x-deflate …
KhafraDev Mar 31, 2023
7ae1779
perf(fetch): use string comparisons for url schemes (#2038)
KhafraDev Apr 1, 2023
549e7ed
util: replace util.toUSVString with String.prototype.toWellFormed (#2…
KhafraDev Apr 1, 2023
a6d1474
build(deps): bump github/codeql-action from 2.2.4 to 2.2.9 (#2039)
dependabot[bot] Apr 1, 2023
3d21d22
build(deps-dev): bump concurrently from 7.6.0 to 8.0.1 (#2041)
dependabot[bot] Apr 3, 2023
5f3b8e1
Small performance improvements (#2044)
anonrig Apr 4, 2023
eceaf9a
fix(types): Add missing Blob import (#2047)
dpogue Apr 4, 2023
816dcaa
fix: set window option properly (#2048)
KhafraDev Apr 5, 2023
a1846e5
fetch: fix leak (#2049)
ronag Apr 8, 2023
2d94417
5.21.1
ronag Apr 8, 2023
fb84aac
Content disposition parsing (#2051)
KhafraDev Apr 8, 2023
0562e9b
fix: clear set-cookie headers (#2052)
KhafraDev Apr 8, 2023
b20405e
5.21.2
ronag Apr 9, 2023
31884e6
build(deps-dev): bump tsd from 0.27.0 to 0.28.1 (#2042)
dependabot[bot] Apr 9, 2023
8c07892
build(deps): bump ossf/scorecard-action from 2.1.2 to 2.1.3 (#2040)
dependabot[bot] Apr 9, 2023
fa4ba00
fix: handle opaque origin in sameOrigin (#2053)
KhafraDev Apr 9, 2023
dfaec78
test: add typescript import test back (#2054)
KhafraDev Apr 9, 2023
b3eb287
feat: port H2 work with latest main
metcoder95 Apr 12, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: don't set socket on client before init
  • Loading branch information
ronag committed Jan 20, 2023
commit f61a902fcf138e0b13c68ab7496ee0c15e708f3a
8 changes: 4 additions & 4 deletions lib/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -1074,8 +1074,6 @@ async function connect (client) {

assert(socket)

client[kSocket] = socket

socket[kNoRef] = false
socket[kWriting] = false
socket[kReset] = false
Expand All @@ -1091,6 +1089,8 @@ async function connect (client) {
.on('end', onSocketEnd)
.on('close', onSocketClose)

client[kSocket] = socket

if (channels.connected.hasSubscribers) {
channels.connected.publish({
connectParams: {
Expand Down Expand Up @@ -1176,7 +1176,7 @@ function _resume (client, sync) {

const socket = client[kSocket]

if (socket) {
if (socket && !socket.destroyed) {
if (client[kSize] === 0) {
if (!socket[kNoRef] && socket.unref) {
socket.unref()
Expand Down Expand Up @@ -1243,7 +1243,7 @@ function _resume (client, sync) {

if (!socket) {
connect(client)
continue
return
}

if (socket.destroyed || socket[kWriting] || socket[kReset] || socket[kBlocking]) {
Expand Down