Code generation fix #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Augkit
reviewed
Jun 20, 2023
| const FString ValueStr = GetCode_GetPropertyValueFrom(TargetInstance); | ||
| const FString FieldValueStr = GetCode_GetProtoFieldValueFrom(NewStateName); | ||
| const FNumericProperty* NumericProperty = Cast<FNumericProperty>(OriginalProperty); | ||
| if (NumericProperty && NumericProperty->IsEnum()) |
There was a problem hiding this comment.
Recommend overriding GetCode_GetPropertyValueFrom by inheriting PropertyDecoratory.
- Perform the following operations under /Source/ReplicatorGenerator/<Public|Private>/PropertyDecoratory directory.
- Create BoolPropertyDecoratory.<h|.cpp> and EnumPropertyDecoratory.<h|.cpp>, and override
GetCode_GetPropertyValueFrom. - Change
BASE_DATA_TYPE_PROPERTY_DECORATOR_WITH_BUILDER(FBoolPropertyDecoratorBuilder, FBoolPropertyDecorator, FBoolProperty, bool)in BaseDataTypePropertyDecorator.h toBASE_DATA_TYPE_PROPERTY_DECORATOR_BUILDER(FBoolPropertyDecoratorBuilder, FBoolPropertyDecorator, FBoolProperty). - Create EnumPropertyDecoratoryBuilder.<h|.cpp> and rewrite
IsSpecialPropertyandConstructPropertyDecoratorby referring to VectorPropertyDecoratorBuilder. - Add
->SetNextBuilder(MakeShared<EnumPropertyDecoratoryBuilder>())after line 18 of FPropertyDecoratorFactory.cpp.
laughxing
force-pushed
the
code_generation_fix
branch
from
ddc410e
to
f6e4a41
Compare
laughxing
force-pushed
the
code_generation_fix
branch
from
aa8455e
to
b58480a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.