Register non ActiveRecord::Base classes correctly #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that I look at it, I am not sure why that is there. I certainly like your test added and it should be allowed. BTW, that require_relative will have to go for the test to pass in 1.8.7. |
| @@ -0,0 +1,16 @@ | |||
| require 'test_helper_dummy' | |||
| require_relative '../dummy_app/lib/library' | |||
There was a problem hiding this comment.
This could be require "#{Dummy::Application.root}/lib/library"
metaskills
added a commit
that referenced
this pull request
Mar 20, 2013
Register non ActiveRecord::Base classes correctly
|
Released v4.7.2. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to v4.7.1 my
beforeandafterhooks stopped working while running my specs for all classes that didn't inherit fromActiveRecord::Base(classes stored inlibfor instance).I assume there's a valid reason for the
ActiveRecord::Baseinherit check?