Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User guide: explain root device hints #457

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Jul 4, 2024

Add plenty of links to the new document since it's quite important and
often overlooked. Explain how the deprecated profiles are related to it.
Provide an example of using HardwareData (another often overlooked
feature).

Also sneak in a couple of fixes for invalid relative URLs (sorry!).

Signed-off-by: Dmitry Tantsur [email protected]

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 4, 2024
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit.

Thanks for contributing many valuable documentation improvements @dtantsur !

docs/user-guide/src/bmo/root_device_hints.md Show resolved Hide resolved
docs/user-guide/src/bmo/root_device_hints.md Outdated Show resolved Hide resolved
Add plenty of links to the new document since it's quite important and
often overlooked. Explain how the deprecated profiles are related to it.
Provide an example of using HardwareData (another often overlooked
feature).

Also sneak in a couple of fixes for invalid relative URLs (sorry!).

Signed-off-by: Dmitry Tantsur <[email protected]>
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2024
@metal3-io-bot metal3-io-bot merged commit ff8d27e into metal3-io:main Jul 5, 2024
8 checks passed
@dtantsur dtantsur deleted the rootdevicehints branch July 5, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants