Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Bump controller-runtime, k8s/*, CAPM3/test and other related go modules #1515

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

kashifest
Copy link
Member

@kashifest kashifest commented Jan 9, 2024

Bump

  • sigs.k8s.io/controller-runtime to v0.16.3
  • k8s.io/* to v0.28.5
  • github.com/metal3-io/cluster-api-provider-metal3/test to v1.6.0

MetricsBindAddress is deprecated. We now use metricsServer options to accomodate the bindAddress

@metal3-io-bot metal3-io-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 9, 2024
@kashifest
Copy link
Member Author

/hold
Need to check the failures

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2024
@kashifest kashifest force-pushed the bump/test-modules branch 2 times, most recently from 878251b to 968b964 Compare January 10, 2024 07:54
@kashifest
Copy link
Member Author

/metal3-bmo-e2e-test
/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@kashifest
Copy link
Member Author

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2024
@kashifest
Copy link
Member Author

/cc @zaneb @honza @dtantsur

@tuminoid
Copy link
Member

Can you mention in the description why the metrics is removed?

@kashifest
Copy link
Member Author

Can you mention in the description why the metrics is removed?

Done

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
main.go Show resolved Hide resolved
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
@kashifest
Copy link
Member Author

/metal3-bmo-e2e-test
/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@kashifest kashifest requested a review from zaneb January 15, 2024 11:55
@zaneb
Copy link
Member

zaneb commented Jan 15, 2024

Thanks!
/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2024
@metal3-io-bot metal3-io-bot merged commit fc4a036 into metal3-io:main Jan 16, 2024
18 checks passed
@metal3-io-bot metal3-io-bot deleted the bump/test-modules branch January 16, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants