Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert ":seedling: Bump github.com/golangci/golangci-lint in /hack/tools" #1299

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jun 22, 2023

This reverts commit ebbacc4.

This did not get tested properly by PROW since it was not touching any Go source files directly, and is making everything fail due stricter linter rules.

…ols"

This reverts commit ebbacc4.

This did not get tested properly by PROW and is making everything
fail due stricter linter rules.
@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 22, 2023
@tuminoid
Copy link
Member Author

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

@dtantsur
Copy link
Member

/approve
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2023
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2023
@tuminoid
Copy link
Member Author

/override test-ubuntu-integration-main
/override test-centos-e2e-integration-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-e2e-integration-main, test-ubuntu-integration-main

In response to this:

/override test-ubuntu-integration-main
/override test-centos-e2e-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot merged commit 9e1d11b into metal3-io:main Jun 22, 2023
8 checks passed
@tuminoid tuminoid deleted the tuomo/revert-golangcilint-bump branch June 22, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants