Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Fix mac address for demo and fixture provisioners #1188

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Dec 1, 2022

What this PR does / why we need it:

The demo and fixture provisioners had invalid MAC addresses hard coded. Now that we have validation of them it is necessary to have proper addresses for things to work.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 1, 2022
@lentzi90
Copy link
Member Author

lentzi90 commented Dec 1, 2022

/test-ubuntu-integration-main
/test-centos-integration-main

@honza
Copy link
Member

honza commented Dec 1, 2022

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza, mboukhalfa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2022
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2022
@metal3-io-bot metal3-io-bot merged commit 1a15b74 into metal3-io:main Dec 1, 2022
@lentzi90 lentzi90 deleted the lentzi90/fix-demo-fixture branch December 1, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants