Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BMH architecture is hard-coded from the profile before inspection #1270

Closed
yanfeng1992 opened this issue May 4, 2023 · 3 comments
Closed

BMH architecture is hard-coded from the profile before inspection #1270

yanfeng1992 opened this issue May 4, 2023 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@yanfeng1992
Copy link

User Story

In a multi-architecture scenario, I want to get the cpu architecture from bmh to set the Architecture field in PreprovisioningImage. Now the implementation in getHostArchitecture is obtained from the host.Status.HardwareDetails.CPU.Arch field, or from the profile. This It does not meet the needs of my scene.

Can you provide a way to manually set the cpu architecture when creating bmh？

#1252

Detailed Description

[A clear and concise description of what you want to happen.]

Anything else you would like to add:

[Miscellaneous information that will assist in solving the issue.]

/kind feature
@metal3-io-bot metal3-io-bot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels May 4, 2023
@dtantsur dtantsur changed the title How to get cpu architecture from bmh BMH architecture is hard-coded from the profile before inspection May 4, 2023
@dtantsur
Copy link
Member

dtantsur commented May 4, 2023

/triage accepted
/kind bug

We've hit this downstream recently, it's pretty annoying. After inspection, the correct data will be there, but you may need it for inspection.

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels May 4, 2023
@dtantsur dtantsur removed the kind/feature Categorizes issue or PR as related to a new feature. label May 4, 2023
@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 2, 2023
@honza
Copy link
Member

honza commented Aug 2, 2023

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 2, 2023
dtantsur added a commit to dtantsur/baremetal-operator that referenced this issue Aug 9, 2023
@dtantsur
Add an explicit Architecture field (closes metal3-io#1270)
9070ee8
dtantsur added a commit to dtantsur/baremetal-operator that referenced this issue Aug 10, 2023
@dtantsur
Add an explicit Architecture field (closes metal3-io#1270)
2b2f311
metal3-io-bot added a commit that referenced this issue Aug 14, 2023
@metal3-io-bot
Merge pull request #1328 from dtantsur/architecture
2c1a768 
✨ Add an explicit Architecture field (closes #1270)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@honza @dtantsur @metal3-io-bot @yanfeng1992