This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
[BUG-FIX] "Recent Searches" list doesn't work because of changed result list structure #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Trigger
#52 made a lot of changes to the UI and the JS code.
result-link
a.result-link
toa.result-link > div h1
div
orh1
, and neither of them have theresult-link
class, so the click handler would not consider the clicked element as a result link and won't add the search term to the recent searches listlocalStorage
ul.local-storage-list div > a
ul.local-storage-list > li > a
Impact
Fix
a.result-link
=> This ensures that the handler is triggered whenever thea
or one of it's children are clickedI have tested this locally in a bunch of scenarios and it works as expected. 👍
Fix #54
Other changes in this PR
semistandard --lint
on the JS file in a later PR.