-
Notifications
You must be signed in to change notification settings - Fork 23
Add ability to pre-fill the search bar from URL param #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor change required.
Irrespective of the query in the url param, a /
gets added at last - which messes up the search results at times.
Search as input to search bar :
Notice the 2nd result missing in case 1. Maybe just the /
can be removed from the search_query
variable in line 107?
I added that search engine to Chrome 56. Then, I searched using the address bar. There was no
Who adds the |
@athityakumar Can you post the search engine entry here? You might have put a In any case, it will be a good idea to remove trailing forward slashes. So, you should change your PR on the other issue to ensure that the last character is a forward slash before slicing it away. 😄 |
@icyflame - Um, isn't it the |
Hmm, okay, I guess your browser decided to append the Okay, I will merge that PR and that should update the commit here. |
Weird o weird. 😕 I've updated the other PR. 😄 |
Removes / at end of search url param
@athityakumar Merged. I have tested with multiple trailing forward slashes, works fine. |
@icyflame - No more issues from my side, I've approved the PR. Let's wait for reviews of @vivekiitkgp & @amrav before merging this in. 😄 |
@vivekiitkgp and @amrav Please review this PR. 🙂 I will merge this PR in a few hours. Thanks! |
This will enable the addition of MFQP as a custom search engine in Chrome. (with a URL structure something like:
https://qp.metakgp.org/?search=%s
I have tested this change, and it works well.