Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

added link to mfqp-source repository #19

Merged
merged 2 commits into from
Mar 11, 2017
Merged

Conversation

ayuhsya
Copy link
Contributor

@ayuhsya ayuhsya commented Mar 11, 2017

  • Added link to the repository at the bottom of the page.
  • Removed FB social plugin button's background image.

@raivivek
Copy link
Member

How does it look? A screenshot perhaps?

@ayuhsya
Copy link
Contributor Author

ayuhsya commented Mar 11, 2017

Here's a screenshot:
image

@raivivek
Copy link
Member

raivivek commented Mar 11, 2017

I think the issue meant linking to the https://metakgp.github.io/mfqp-source/ (webpage) where people can see the link to upload paper along with stats. The idea is this: when people go to mfqp to download papers, they see the "call" to upload papers and follow the link to do so. Linking to source is useful but not what we want.

You should link to this site along with a message like "Upload papers?" or "Question Paper Collection Drive" as you see fit.

@ayuhsya
Copy link
Contributor Author

ayuhsya commented Mar 11, 2017

@vivekiitkgp Oh! So will it be fine if I just add the text "Upload Paper" instead of the Github logo?

@raivivek
Copy link
Member

Yeah. Perhaps put the fb social thing (on next line) below "Upload a paper". That should do.

@ayuhsya
Copy link
Contributor Author

ayuhsya commented Mar 11, 2017

@vivekiitkgp Is this fine?
image

@raivivek
Copy link
Member

raivivek commented Mar 11, 2017 via email

@ayuhsya
Copy link
Contributor Author

ayuhsya commented Mar 11, 2017

@vivekiitkgp I cannot seem to find a more suitable way to emphasize the Upload button as the page is in black and white. Increasing font size doesn't seem good either. Please merge this itself.

@athityakumar
Copy link
Member

@ayuhsya - Can you add padding to the the "Upload a paper" button? Rest of it looks good to me.

@ayuhsya
Copy link
Contributor Author

ayuhsya commented Mar 11, 2017

Looks like this now:
image

Copy link
Member

@athityakumar athityakumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the Pull Request, @ayuhsya . I'm looking forward to see more of such contributions from you. 😄

@icyflame
Copy link
Member

@athityakumar @vivekiitkgp Um, we didn't really decide to stick to grayscale really. So, if a little bit of color is required to spruce this page up and make the Upload button seem more prominent, go for it @ayuhsya.

@raivivek raivivek merged commit 6755d4e into metakgp:gh-pages Mar 11, 2017
@ayuhsya ayuhsya deleted the dev branch March 11, 2017 20:26
@hargup
Copy link
Member

hargup commented Mar 12, 2017

I think there is some mistake. The page looks like this to me, button linking to the upload page, says "github" instead of "Upload Question Paper".

@raivivek
Copy link
Member

raivivek commented Mar 12, 2017

@hargup Take a look at PR #24. Edit: I think the change was reverted by mistake in the commit bdeab25. @ayuhsya

@ayuhsya
Copy link
Contributor Author

ayuhsya commented Mar 12, 2017

@vivekiitkgp Yes, I fixed this in PR #24. Please review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants