-
Notifications
You must be signed in to change notification settings - Fork 23
Conversation
ayuhsya
commented
Mar 11, 2017
•
edited
Loading
edited
- Added link to the repository at the bottom of the page.
- Removed FB social plugin button's background image.
How does it look? A screenshot perhaps? |
I think the issue meant linking to the https://metakgp.github.io/mfqp-source/ (webpage) where people can see the link to upload paper along with stats. The idea is this: when people go to mfqp to download papers, they see the "call" to upload papers and follow the link to do so. Linking to source is useful but not what we want. You should link to this site along with a message like "Upload papers?" or "Question Paper Collection Drive" as you see fit. |
@vivekiitkgp Oh! So will it be fine if I just add the text "Upload Paper" instead of the Github logo? |
Yeah. Perhaps put the fb social thing (on next line) below "Upload a paper". That should do. |
@vivekiitkgp Is this fine? |
Looks fine to me. If you want to make it better in any way, feel free.
Otherwise, I am happy to have this merged.
…On Sat, Mar 11, 2017 at 4:07 PM, Ayushya Anand ***@***.***> wrote:
Is this fine?
[image: image]
<https://cloud.githubusercontent.com/assets/8494774/23822573/c37fe870-0674-11e7-8147-39a1261b343d.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADEcuVbTZnTyeii-LB94QTnQ3RXRaorhks5rknlagaJpZM4MaJmQ>
.
|
@vivekiitkgp I cannot seem to find a more suitable way to emphasize the Upload button as the page is in black and white. Increasing font size doesn't seem good either. Please merge this itself. |
@ayuhsya - Can you add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the Pull Request, @ayuhsya . I'm looking forward to see more of such contributions from you. 😄
@athityakumar @vivekiitkgp Um, we didn't really decide to stick to grayscale really. So, if a little bit of color is required to spruce this page up and make the Upload button seem more prominent, go for it @ayuhsya. |
@vivekiitkgp Yes, I fixed this in PR #24. Please review. |