Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown Error if email is not activated #5

Open
hargup opened this issue Jun 23, 2016 · 11 comments
Open

Unknown Error if email is not activated #5

hargup opened this issue Jun 23, 2016 · 11 comments
Labels

Comments

@hargup
Copy link
Member

hargup commented Jun 23, 2016

@Schrodinger1926 reported that he encountered the following error while trying to save an edit, but the error was fixed after he activated his email. @icyflame can you look into this?
screen shot 2016-06-23 at 02 52 49

@hargup hargup added the bug label Jun 23, 2016
@icyflame
Copy link
Member

@hargup Is this a bug? Pretty sure that email activation is required for making edits on the wiki. Maybe we can change the error text. That could help.

@hargup
Copy link
Member Author

hargup commented Jun 23, 2016

Yes we should provide more helpful error messages. Though I think it shouldn't be necessary to verify the emails of contributors, it can be unnecessary bother at times. Cases of vandalism are quite low, we can revise the policy in future if necessary.

@hargup
Copy link
Member Author

hargup commented Jul 31, 2016

@icyflame can you turn off the requirement for email validation I came across another instance today where this proved to be a barrier where I was editing a page without being logged in and the error forced me to log in making me loose the work.

@icyflame
Copy link
Member

@hargup Really? I can make anonymous edits without doing anything. I don't even have to login to make anon edits through IP.

@hargup
Copy link
Member Author

hargup commented Jul 31, 2016

I can make anonymous edits without doing anything. I don't even have to login to make anon edits through IP.

This "Unknown Error" occurred while making an anon edit using visual editor, but I cannot reproduce it.

@amrav
Copy link
Member

amrav commented Aug 1, 2016

Think carefully about whether you want to turn off email validation. That
would mean that user accounts can now be run by spambots more easily.

On Sun, 31 Jul 2016 at 16:28 Harsh Gupta [email protected] wrote:

I can make anonymous edits without doing anything. I don't even have to
login to make anon edits through IP.

This "Unknown Error" occurred while making an anon edit using visual
editor, but I cannot reproduce it.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#5 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABIZ_-G6pUdoafPdgq1KSvfWO49UHis6ks5qbH-4gaJpZM4I8f80
.

@Schrodinger1926
Copy link

@hargup @amrav I would suggest to just show a more informative message when a user tries to make an edit without activating his/her email id. Currently it shows something went wrong which gives no clue to user.
I agree with @amrav, turning off email validation doesn't seems to be a good idea.

@hargup
Copy link
Member Author

hargup commented Aug 1, 2016

Think carefully about whether you want to turn off email validation. That would mean that user accounts can now be run by spambots more easily.

We require the users to enter a CAPTCHA, shouldn't it be good enough to fight the bots?

@icyflame
Copy link
Member

icyflame commented Aug 1, 2016

@hargup I don't know if this is a problem anymore. We can show a more informative message, removing email validation isn't a good idea. And since you can't reproduce the problem you had, it's probably a one-off, we can try something if the problem re-appears for someone.

@icyflame
Copy link
Member

This bug couldn't be reproduced. Was a one-off, most probably. If anyone else faces this again, then we can consider fixing it by tracking the exact events.

Verifying email is required if user wants to have an account on the Wiki. Of course, anon edits can be made with attribution to the IP.

@hargup
Copy link
Member Author

hargup commented Mar 26, 2017

Encountered the error with another person, need to investigate this more. See #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants