Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused POST /api/user/:id/send_invite endpoint #41369

Open
nemanjaglumac opened this issue Apr 12, 2024 · 2 comments
Open

Remove unused POST /api/user/:id/send_invite endpoint #41369

nemanjaglumac opened this issue Apr 12, 2024 · 2 comments
Labels
.Backend 🧹 no-brainer cleanup issues to clear out when you have an hour left until EoD or something Type:Tech Debt or Refactoring

Comments

@nemanjaglumac
Copy link
Member

This endpoint still exists on the backend, and is defined on the frontend in both services and in the Users entity but it's not being called anywhere.

The last backend change:
https://github.com/metabase/metabase/pull/31398/files#diff-b0c224851be83561f142d58168ee2b5bb88452d535cb116e620616af3b858ed6L493-R495

Slack context:
https://metaboat.slack.com/archives/C01LQQ2UW03/p1712930250085399
@nemanjaglumac nemanjaglumac added Type:Tech Debt or Refactoring 🧹 no-brainer cleanup issues to clear out when you have an hour left until EoD or something labels Apr 12, 2024
@nemanjaglumac nemanjaglumac self-assigned this Apr 12, 2024
nemanjaglumac added a commit that referenced this issue Apr 12, 2024
@nemanjaglumac
Remove POST /api/user/:id/send_invite endpoint
ec2e8bb 
Resolves #41369
@nemanjaglumac nemanjaglumac mentioned this issue Apr 12, 2024
Closed
@kamilmielnik
Copy link
Contributor

I see #41370 got closed but we can still remove references to this endpoint in the FE code.

@nemanjaglumac
Copy link
Member Author

I see #41370 got closed but we can still remove references to this endpoint in the FE code.

@kamilmielnik yup, that's happening here 57e0130

@nemanjaglumac nemanjaglumac removed their assignment Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
.Backend 🧹 no-brainer cleanup issues to clear out when you have an hour left until EoD or something Type:Tech Debt or Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove POST /api/user/:id/send_invite endpoint metabase/metabase
2 participants
@kamilmielnik @nemanjaglumac