Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #635

Merged
merged 12 commits into from
Feb 7, 2022
Merged

Develop #635

merged 12 commits into from
Feb 7, 2022

Conversation

sidharthv96
Copy link
Member

📑 Summary

Brief description about the content of your PR:

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable:

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

dependabot bot and others added 8 commits February 4, 2022 08:38
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.5 to 8.4.6.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.5...8.4.6)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [tailwindcss](https://github.com/tailwindlabs/tailwindcss) from 3.0.17 to 3.0.18.
- [Release notes](https://github.com/tailwindlabs/tailwindcss/releases)
- [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/master/CHANGELOG.md)
- [Commits](tailwindlabs/tailwindcss@v3.0.17...v3.0.18)

---
updated-dependencies:
- dependency-name: tailwindcss
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…629)

Bumps [eslint-plugin-tailwindcss](https://github.com/francoismassart/eslint-plugin-tailwindcss) from 3.3.6 to 3.4.3.
- [Release notes](https://github.com/francoismassart/eslint-plugin-tailwindcss/releases)
- [Commits](francoismassart/eslint-plugin-tailwindcss@v3.3.6...v3.4.3)

---
updated-dependencies:
- dependency-name: eslint-plugin-tailwindcss
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
….260 (#631)

* chore(deps-dev): bump @sveltejs/kit

Bumps [@sveltejs/kit](https://github.com/sveltejs/kit/tree/HEAD/packages/kit) from 1.0.0-next.247 to 1.0.0-next.260.
- [Release notes](https://github.com/sveltejs/kit/releases)
- [Changelog](https://github.com/sveltejs/kit/blob/master/packages/kit/CHANGELOG.md)
- [Commits](https://github.com/sveltejs/kit/commits/@sveltejs/[email protected]/packages/kit)

---
updated-dependencies:
- dependency-name: "@sveltejs/kit"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update svelte.config.js

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matthieu MOREL <[email protected]>
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 12.3.2 to 12.3.3.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Commits](lint-staged/lint-staged@v12.3.2...v12.3.3)

---
updated-dependencies:
- dependency-name: lint-staged
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [cypress](https://github.com/cypress-io/cypress) from 9.3.1 to 9.4.1.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Changelog](https://github.com/cypress-io/cypress/blob/develop/.releaserc.base.js)
- [Commits](cypress-io/cypress@v9.3.1...v9.4.1)

---
updated-dependencies:
- dependency-name: cypress
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [monaco-editor](https://github.com/microsoft/monaco-editor) from 0.31.1 to 0.32.0.
- [Release notes](https://github.com/microsoft/monaco-editor/releases)
- [Changelog](https://github.com/microsoft/monaco-editor/blob/main/CHANGELOG.md)
- [Commits](https://github.com/microsoft/monaco-editor/commits)

---
updated-dependencies:
- dependency-name: monaco-editor
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [svelte](https://github.com/sveltejs/svelte) from 3.46.3 to 3.46.4.
- [Release notes](https://github.com/sveltejs/svelte/releases)
- [Changelog](https://github.com/sveltejs/svelte/blob/master/CHANGELOG.md)
- [Commits](sveltejs/svelte@v3.46.3...v3.46.4)

---
updated-dependencies:
- dependency-name: svelte
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Feb 4, 2022

✔️ Deploy Preview for mermaidjs ready!

🔨 Explore the source changes: bb5f8d0

🔍 Inspect the deploy log: https://app.netlify.com/sites/mermaidjs/deploys/62016385f4aaad00079ca8a6

😎 Browse the preview: https://deploy-preview-635--mermaidjs.netlify.app

@cypress
Copy link

cypress bot commented Feb 4, 2022



Test summary

21 0 1 0


Run details

Project Mermaid Live Editor
Status Passed
Commit 38594a3 ℹ️
Started Feb 7, 2022 6:24 PM
Ended Feb 7, 2022 6:27 PM
Duration 02:58 💡
OS Linux Debian - 10.8
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

The action didn't run previously.
@sidharthv96
Copy link
Member Author

I think cy.tick() is messing with some internal implementation related to time inside monaco.
We could disable this test and merge as it's not a critical issue.
@mmorel-35, @Yash-Singh1 any ideas for a proper fix?

@mmorel-35
Copy link
Contributor

Does the test passes if we rollback cypress update ?
In that case It would be better to stick with the previous version and create an issue at cypress in order to fix it?

@sidharthv96
Copy link
Member Author

sidharthv96 commented Feb 7, 2022

I've posted a message in cypress help channel.
Rolling back cypress didn't fix the issue. I'm guessing it's realed to monaco.

Also, @mmorel-35 any idea why the monaco update action did not run for the dependabot PR? I ran it manually in this.

@mmorel-35
Copy link
Contributor

The Monaco update probably didn't work because of the type field on pull_request, that was too much precise

@sidharthv96 sidharthv96 merged commit cf2e6f4 into master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants