Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressed URL #604

Merged
merged 8 commits into from
Jan 21, 2022
Merged

Compressed URL #604

merged 8 commits into from
Jan 21, 2022

Conversation

sidharthv96
Copy link
Member

@sidharthv96 sidharthv96 commented Jan 20, 2022

📑 Summary

Brief description about the content of your PR: Add compressed URL support

Resolves #597

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable:

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@netlify
Copy link

netlify bot commented Jan 20, 2022

✔️ Deploy Preview for mermaidjs ready!

🔨 Explore the source changes: 9fb7c4a

🔍 Inspect the deploy log: https://app.netlify.com/sites/mermaidjs/deploys/61e9b3ebf669ee0008afa8f7

😎 Browse the preview: https://deploy-preview-604--mermaidjs.netlify.app

@sidharthv96 sidharthv96 linked an issue Jan 20, 2022 that may be closed by this pull request
@sidharthv96 sidharthv96 self-assigned this Jan 20, 2022
* develop:
  chore(deps): bump daisyui from 1.21.0 to 1.24.3
  chore(deps-dev): bump lint-staged from 12.2.0 to 12.2.1
  chore(deps-dev): bump cssnano from 5.0.14 to 5.0.15 (#600)
  chore(deps-dev): bump autoprefixer from 10.4.0 to 10.4.2
  chore(deps): bump pako from 1.0.10 to 2.0.4
  chore(deps): bump mermaid from 8.13.8 to 8.13.9
  chore(deps-dev): bump cypress from 9.2.0 to 9.3.1
  chore(deps-dev): bump mocha from 9.1.3 to 9.1.4
  chore(deps-dev): bump eslint-plugin-tailwindcss from 1.17.2 to 3.3.0
@cypress
Copy link

cypress bot commented Jan 20, 2022



Test summary

21 0 0 0


Run details

Project Mermaid Live Editor
Status Passed
Commit 5a727fb ℹ️
Started Jan 20, 2022 7:13 PM
Ended Jan 20, 2022 7:16 PM
Duration 03:06 💡
OS Linux Debian - 10.8
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@sidharthv96
Copy link
Member Author

jihchi/mermaid.ink#33

@sidharthv96 sidharthv96 added the enhancement New feature or request label Jan 20, 2022
@sidharthv96
Copy link
Member Author

@jihchi please let me know once the merged code is deployed so we can have a smooth transition.

This URL is throwing an error now.

https://mermaid.ink/img/pako:eNpVkM1qw0AMhF9F6NRC_AI-BBo7zSWQQHLz5iC8SnZJ9gd5TQm2373r_ECrk9B8MwwasA2ascSLUDRwrJWHPF9NZcR2yVF3gqJYjhtO4ILn-wirj02AzoQYrb98PvnVDEE1bGeMIRnrr9NTqh7-necR6mZLMYV4-qscf8II68buTY7_rxjh7PpuzlSeqWhJoCJ5IbhAx-LI6lx-mG8Kk2HHCsu8apKrQuWnzPVRU-K1tikI5qRbxwukPoXD3bdYJun5DdWW8iPci5p-AUT3W9o

Works fine in my local machine.

http:https://localhost:3000/img/pako:eNpVkM1qw0AMhF9F6NRC_AI-BBo7zSWQQHLz5iC8SnZJ9gd5TQm2373r_ECrk9B8MwwasA2ascSLUDRwrJWHPF9NZcR2yVF3gqJYjhtO4ILn-wirj02AzoQYrb98PvnVDEE1bGeMIRnrr9NTqh7-necR6mZLMYV4-qscf8II68buTY7_rxjh7PpuzlSeqWhJoCJ5IbhAx-LI6lx-mG8Kk2HHCsu8apKrQuWnzPVRU-K1tikI5qRbxwukPoXD3bdYJun5DdWW8iPci5p-AUT3W9o

@jihchi
Copy link
Contributor

jihchi commented Jan 20, 2022

@sidharthv96 I have deployed latest code to mermaid.ink, it is working now.

@sidharthv96 sidharthv96 merged commit d603927 into develop Jan 21, 2022
@mmorel-35 mmorel-35 deleted the sidv/compress branch January 21, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compressed URL support
3 participants