Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Use monaco-mermaid"" #586

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

sidharthv96
Copy link
Member

Reverts #585

@netlify
Copy link

netlify bot commented Jan 18, 2022

✔️ Deploy Preview for mermaidjs ready!

🔨 Explore the source changes: 73168de

🔍 Inspect the deploy log: https://app.netlify.com/sites/mermaidjs/deploys/61ea385ff87e7b00075aa3bd

😎 Browse the preview: https://deploy-preview-586--mermaidjs.netlify.app

@cypress
Copy link

cypress bot commented Jan 18, 2022



Test summary

19 0 0 0


Run details

Project Mermaid Live Editor
Status Passed
Commit 3607843 ℹ️
Started Jan 21, 2022 4:39 AM
Ended Jan 21, 2022 4:43 AM
Duration 03:57 💡
OS Linux Debian - 10.8
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@Yash-Singh1
Copy link
Member

The problem seems to be coming because colors is required in the theme: https://microsoft.github.io/monaco-editor/api/interfaces/monaco.editor.IStandaloneThemeData.html

@sidharthv96 sidharthv96 merged commit f107838 into develop Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export Syntax Highlighting as a Seperate Package and import in MermaidJS docs
2 participants