Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use monaco-mermaid #478

Merged
merged 7 commits into from
Jan 17, 2022
Merged

Use monaco-mermaid #478

merged 7 commits into from
Jan 17, 2022

Conversation

Yash-Singh1
Copy link
Member

@Yash-Singh1 Yash-Singh1 commented Oct 31, 2021

Related mermaid-js/mermaid#2449
Related #404

@netlify
Copy link

netlify bot commented Oct 31, 2021

✔️ Deploy Preview for mermaidjs ready!

🔨 Explore the source changes: bef34c8

🔍 Inspect the deploy log: https://app.netlify.com/sites/mermaidjs/deploys/61badea843740b0007f290f1

😎 Browse the preview: https://deploy-preview-478--mermaidjs.netlify.app

@mmorel-35
Copy link
Contributor

Hi @Yash-Singh1, did you forget to also update the yarn.lock file?

@Yash-Singh1
Copy link
Member Author

Yeah, I didn’t use yarn, could you update that? Because I am not in the environment where I can do that.

@mmorel-35
Copy link
Contributor

My usual trick when I have no access to a computer is this gist: https://gist.github.com/mmorel-35/0972d561d1a4b0a67784c4e67314cf3b

You run a "workflow_dispatch" with a "add-and-commit" after running your commands. Can you do that? Or we will wait until the first of us can do it

@Yash-Singh1
Copy link
Member Author

My usual trick when I have no access to a computer is this gist: https://gist.github.com/mmorel-35/0972d561d1a4b0a67784c4e67314cf3b

You run a "workflow_dispatch" with a "add-and-commit" after running your commands. Can you do that? Or we will wait until the first of us can do it

Thanks for the trick! I’ll use that next time.

@sidharthv96
Copy link
Member

@Yash-Singh1 can you resolve the conflicts?

@sidharthv96 sidharthv96 merged commit c6028f0 into mermaid-js:develop Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export Syntax Highlighting as a Seperate Package and import in MermaidJS docs
3 participants