Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code is not editable when error is thrown #851

Closed
sidharthv96 opened this issue Jun 20, 2022 · 1 comment · Fixed by #864
Closed

Code is not editable when error is thrown #851

sidharthv96 opened this issue Jun 20, 2022 · 1 comment · Fixed by #864
Assignees
@sidharthv96
Labels
bug Something isn't working

Comments

@sidharthv96
Copy link
Member

Describe the bug
Not able to edit code with error

To Reproduce
Link to Live Editor: https://mermaidjs.github.io/mermaid-live-editor/#/edit/eyJjb2RlIjoiZ2l0R3JhcGg6XG5vcHRpb25zXG57XG4gICAgXCJub2RlU3BhY2luZ1wiOiAxNTAsXG4gICAgXCJub2RlUmFkaXVzXCI6IDEwXG59XG5lbmRcbmNvbW1pdFxuYnJhbmNoIG5ld2JyYW5jaFxuY2hlY2tvdXQgbmV3YnJhbmNoXG5jb21taXRcbmNvbW1pdFxuY2hlY2tvdXQgbWFzdGVyXG5jb21taXRcbmNvbW1pdFxubWVyZ2UgbmV3YnJhbmNoXG4iLCJtZXJtYWlkIjp7InRoZW1lIjoiZGVmYXVsdCJ9fQ
Steps to reproduce the behavior:

  1. Load link
  2. Try to edit code

Expected behavior
Code is editable
@sidharthv96 sidharthv96 added the bug Something isn't working label Jun 20, 2022
@sidharthv96
Copy link
Member Author

Might be related: mermaid-js/mermaid#3191

sidharthv96 added a commit that referenced this issue Jun 28, 2022
@sidharthv96
Fix #851: Simplify data flow and error handling
457cd02
@sidharthv96 sidharthv96 mentioned this issue Jun 28, 2022
Merged
3 tasks
@sidharthv96 sidharthv96 self-assigned this Jun 28, 2022
sidharthv96 added a commit that referenced this issue Jul 6, 2022
@sidharthv96
Merge branch 'master' into develop
76c4219 
* master:
  fix #796: Export SVG fix
  Fix loading tests
  Bind correct store
  add update test
  Fix #851: Simplify data flow and error handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sidharthv96 sidharthv96

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/data flow mermaid-js/mermaid-live-editor
1 participant
@sidharthv96