added data-format restructuring #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachho
reviewed
Jul 7, 2023
| self.loader = self._get_loader(data_type) | ||
| self.chunker = self._get_chunker(data_type) | ||
|
|
||
| def _get_loader(self, data_type): |
There was a problem hiding this comment.
pretty sure you can make this a static method
|
we don't have to do my proposed changes in this PR. Looks good to me. About the name, classes should be in PascalCase. DataFormatter makes sense since it's Chunker and Loader as well. |
taranjeet
approved these changes
Jul 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of multiple loaders and chunkers the embedchain.py size seems to be growing and I feel it would add to the code-redability by adding some sort of abstraction to the application.