Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: Rename modules for better readability and maintainability #587

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

deshraj
Copy link
Collaborator

@deshraj deshraj commented Sep 11, 2023

Description

Seems like we have longer file names which is kinda unnecessary since the folder names already contain the keywords like llm, db etc. Hence, renaming a lot of modules and updating their import paths.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

  • Unit Test

Copy link
Member

@taranjeet taranjeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. this is a great addition. thanks @deshraj

@taranjeet taranjeet merged commit 79f5a1d into main Sep 11, 2023
3 checks passed
@deshraj deshraj deleted the user/dyadav/fix-file-names branch September 11, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants