Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the chromadb version to 0.4.8 and open its settings configuration. #517

Merged
merged 6 commits into from
Sep 4, 2023

Conversation

mggger
Copy link
Contributor

@mggger mggger commented Aug 31, 2023

Description

  1. update the chromadb version to 0.4.8
  2. allow user can set chromadb settings

Fixes #516

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@mggger
Copy link
Contributor Author

mggger commented Aug 31, 2023

@cachho please help to review 😊

@cachho
Copy link
Contributor

cachho commented Aug 31, 2023

Hey, I'm working on a refactor for the whole database and how it's configured. So I think we're going to have to work on some merge conflicts.

@mggger
Copy link
Contributor Author

mggger commented Aug 31, 2023

@cachho

Okay, if possible in the future, please provide a separate branch for refactoring. I can submit the relevant code on that branch.

@taranjeet
Copy link
Member

@mggger : thanks for your contribution. Looks good to me.

Can you please resolve the merge conflict?

� Conflicts:
�	embedchain/vectordb/chroma_db.py
�	tests/vectordb/test_chroma_db.py
@mggger
Copy link
Contributor Author

mggger commented Sep 4, 2023

@taranjeet Hi, I have resolved the conflicts. Please review it.

@taranjeet
Copy link
Member

Hi @mggger , can you check why the tests are failing?

@mggger
Copy link
Contributor Author

mggger commented Sep 4, 2023

@taranjeet Got it, due to the removal of the "allow_reset" configuration option, the unit test did not pass. It has been fixed.

@taranjeet
Copy link
Member

@mggger : the test are still failing. Can you please check?

@mggger
Copy link
Contributor Author

mggger commented Sep 4, 2023

@taranjeet I'm sorry, previously I only ran test_chroma_db.py, but this time I ran all the unit tests.

@taranjeet taranjeet merged commit eecdbc5 into mem0ai:main Sep 4, 2023
3 checks passed
@taranjeet
Copy link
Member

No worries.
thanks for your PR @mggger
Merged it

@cachho
Copy link
Contributor

cachho commented Sep 4, 2023

I noticed that you disabled allow_reset=True @mggger

@mggger
Copy link
Contributor Author

mggger commented Sep 4, 2023

@cachho Please check the review message above. I left a comment in the review, but it doesn't seem to have been followed up on.

@cachho
Copy link
Contributor

cachho commented Sep 4, 2023

@taranjeet Got it, due to the removal of the "allow_reset" configuration option, the unit test did not pass. It has been fixed.

but how has it been fixed?

@mggger
Copy link
Contributor Author

mggger commented Sep 4, 2023

@cachho Create app with allow_reset

 app = App(
            CustomAppConfig(
                provider=Providers.OPENAI, embedding_fn=EmbeddingFunctions.OPENAI, chroma_settings={"allow_reset": True}
            )
        )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade the chromadb version to 0.4.8 and open its settings configuration.
3 participants