Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Slack bot #469

Merged
merged 26 commits into from
Sep 5, 2023
Merged

feat: Slack bot #469

merged 26 commits into from
Sep 5, 2023

Conversation

cachho
Copy link
Contributor

@cachho cachho commented Aug 23, 2023

Description

Tested, works.

I removed from slackeventsapi import SlackEventAdapter because

a) I couldn't get the event to fire
b) it's essentially just a flask wrapper and we're using flask anyways.
c) it provides little abstraction, it just gives you the json

So yes, I implemented that myself.

Other things to note:

  • event subscribtion verification (requests url) works out of the box with this, you just have to run it.
  • this makes getting the SLACK_SIGNING_TOKEN absolete.
  • the add method of this bot still uses the data_type
  • data_types that don't use a string won't work. As far as I know that's only qna_pair at the moment
  • documentation hasn't been updated. I don't know if you want to keep stuff that references the examples folder. I also don't know if you want this to still be hosted on replit.

Fixes #

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test
  • Test Script (please provide)
  • End-to-end-test in slack

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

Copy link
Collaborator

@deshraj deshraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Left some minor comments.

embedchain/bots/slack.py Outdated Show resolved Hide resolved
embedchain/bots/slack.py Outdated Show resolved Hide resolved
@cachho cachho marked this pull request as ready for review August 24, 2023 15:45
@taranjeet
Copy link
Member

Hey @cachho : the PR looks good. can you please add some docs?

@cachho
Copy link
Contributor Author

cachho commented Sep 3, 2023

Hey @cachho : the PR looks good. can you please add some docs?

ok, will remove examples folder example. Will try to keep replit.

@cachho
Copy link
Contributor Author

cachho commented Sep 4, 2023

Made the changes. Didn't see a reason to keep replit, as this can be self-hosted with ngrok, just like the other examples.

@taranjeet taranjeet merged commit 3059e96 into mem0ai:main Sep 5, 2023
0 of 3 checks passed
taranjeet added a commit that referenced this pull request Sep 6, 2023
Co-authored-by: Taranjeet Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants