Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING CHANGE] moved dry run into query and chat #329

Merged

Conversation

aaishikdutta
Copy link
Contributor

@aaishikdutta aaishikdutta commented Jul 19, 2023

Description

Moved Dry Run into the chat and query method

Fixes #322

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Tested using a script

  • Test Script (please provide)
from embedchain import App

app = App()
app.add("youtube_video", "https://youtu.be/ilIefxbSJT8")
print(app.query("What is Oppenheimer about?", dry_run=True))

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@aaishikdutta aaishikdutta changed the title moved dry run into query and chat [BREAKING CHANGE] moved dry run into query and chat Jul 19, 2023
@taranjeet taranjeet merged commit 4bb0614 into mem0ai:main Jul 20, 2023
3 checks passed
@taranjeet
Copy link
Member

this is good @aaishikdutta

cachho pushed a commit to cachho/embedchain that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ux improvement]: remove dry_run attribute and add this functionality as a kwargs
2 participants