Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added data format to metadata internally #314

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

aaishikdutta
Copy link
Contributor

@aaishikdutta aaishikdutta commented Jul 18, 2023

Description

Added data type to the metadata object.

Fixes #258

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested by logging metadatas_with_metadata variable before pushing to db for a Youtube video:

from embedchain import App

app = App()
app.add("youtube_video", "https://youtu.be/ilIefxbSJT8")


This adds 'embedchain_data_type': 'youtube_video' to the metadata object for each document

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

meta_data = data["meta_data"]
# add data type to meta data to allow query using data type
meta_data["embedchain_data_type"] = self.data_type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we call it data_type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@taranjeet taranjeet merged commit c123624 into mem0ai:main Jul 19, 2023
3 checks passed
cachho pushed a commit to cachho/embedchain that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Automatically add Loader/Format used to Metadata
3 participants