Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: collection name everywhere #310

Merged
merged 19 commits into from
Aug 9, 2023
Merged

feat: collection name everywhere #310

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
2a40d31
feat: allow switching between collections and specifying initial coll…
jonasiwnl Jul 18, 2023
09ec899
Merge branch 'feat/collection-name-everywhere' of https://github.com/…
jonasiwnl Jul 18, 2023
abe9f60
refactor: make collection name everywhere feature compatible with Bas…
jonasiwnl Jul 18, 2023
644c5a1
Merge pull request #1 from jonasiwnl/main
jonasiwnl Jul 18, 2023
201ac5d
chore: remove sentence-transformers dependency
jonasiwnl Jul 18, 2023
5bbcfbc
chore: revert changes to pyproject.toml
jonasiwnl Jul 18, 2023
52f1891
Merge branch 'main' into feat/collection-name-everywhere
cachho Jul 18, 2023
8257bf5
chore: fix merge errors, reformat, remove unused imports
jonasiwnl Jul 18, 2023
1f6b22a
Merge branch 'main' into feat/collection-name-everywhere
jonasiwnl Jul 20, 2023
8d6ec4d
chore: add default collection name to BaseAppConfig
jonasiwnl Jul 28, 2023
ce62702
Merge branch 'main' into feat/collection-name-everywhere
jonasiwnl Jul 28, 2023
ded8ab6
chore: remove default collection name redundancy
jonasiwnl Jul 28, 2023
f69966f
Merge branch 'feat/collection-name-everywhere' of https://github.com/…
jonasiwnl Jul 28, 2023
c8edfed
chore: change collection name to old default
cachho Aug 2, 2023
fee6f94
chore: old default name for compatibility
cachho Aug 2, 2023
cb04be0
refactor: unified argument order
cachho Aug 2, 2023
4dcb811
docs: fix param name
cachho Aug 2, 2023
7d2dfa0
chore: use old default collection name
cachho Aug 2, 2023
1b7b461
test: added unit tests
cachho Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: remove sentence-transformers dependency
  • Loading branch information
@jonasiwnl
jonasiwnl committed Jul 18, 2023
commit 201ac5d4c22a456b7bc2c43f805c292c3c92132d
5 changes: 0 additions & 5 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ youtube-transcript-api = "^0.6.1"
beautifulsoup4 = "^4.12.2"
pypdf = "^3.11.0"
pytube = "^15.0.0"
sentence-transformers = "^2.2.2"



Expand All @@ -107,9 +106,5 @@ click = "^8.1.3"
streamlit = ["streamlit"]


cachho marked this conversation as resolved.
Show resolved Hide resolved
[tool.poetry.group.docs.dependencies]



[tool.poetry.scripts]

5 changes: 0 additions & 5 deletions tests/vectordb/test_chroma_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,6 @@ def test_init_with_custom_collection(self):

self.assertEqual(app.collection.name, "test_collection")

opensourceconfig = OpenSourceAppConfig(collection_name="test_collection1")
opensourceapp = OpenSourceApp(opensourceconfig)

self.assertEqual(opensourceapp.collection.name, "test_collection1")

def test_set_collection(self):
"""
Test if the `App` collection is correctly switched using the `set_collection` method.
Expand Down