Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: app design concept #305

Merged
merged 4 commits into from
Jul 17, 2023
Merged

Conversation

cachho
Copy link
Contributor

@cachho cachho commented Jul 17, 2023

Description

Cleans up the code by refactoring the whole AppConfig and App design concept. Introduces separate configs, that make it clear where defaults are used and what's configurable.

This is a major change, posting so that you can review it while I build changes based on it.

Documentation update not included.

This should work as it is, but it is a breaking change because InitConfig disappears in favor of AppConfig, OpenSourceAppConfig and CustomAppConfig.

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit Test
  • Manual Test (App)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@cachho
Copy link
Contributor Author

cachho commented Jul 17, 2023

Further refactor by moving App classes out of embedchain.py into Apps folder. This is a true refactor that's not breaking anything.

embedchain/config/Apps/AppConfig.py Outdated Show resolved Hide resolved
@taranjeet taranjeet merged commit 0ea278f into mem0ai:main Jul 17, 2023
3 checks passed
This was referenced Jul 18, 2023
cachho added a commit to cachho/embedchain that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants