Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: load chunker from config #270

Merged
merged 11 commits into from
Jul 17, 2023
Merged

chore: load chunker from config #270

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f598b5b
chore: add quick import
cachho Jul 14, 2023
91ac4e7
chore: add dict export and move defaults
cachho Jul 14, 2023
26279dc
chore: load from config class
cachho Jul 14, 2023
ea2487b
fix: do not unpack dict
cachho Jul 14, 2023
8b9fa8f
chore: linting
cachho Jul 14, 2023
1baee60
docs: added chunker config example
cachho Jul 14, 2023
d52b34e
refactor: positive instead of negative formulation
cachho Jul 14, 2023
8fc0f26
Merge branch 'main' into chore/LoadChunkerFromConfig
cachho Jul 17, 2023
92cd365
test: updated test
cachho Jul 17, 2023
4ef25ba
docs: use chunker config
cachho Jul 17, 2023
8d8a0e5
chore: linting
cachho Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: linting
  • Loading branch information
@cachho
cachho committed Jul 17, 2023
commit 8d8a0e51e02ea8ee37eeb44bbd815394735bdeba
4 changes: 1 addition & 3 deletions embedchain/chunkers/docx_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ class DocxFileChunker(BaseChunker):

def __init__(self, config: Optional[ChunkerConfig] = None):
if config is None:
config = ChunkerConfig(
chunk_size=1000, chunk_overlap=0, length_function=len
)
config = ChunkerConfig(chunk_size=1000, chunk_overlap=0, length_function=len)
text_splitter = RecursiveCharacterTextSplitter(
chunk_size=config.chunk_size,
chunk_overlap=config.chunk_overlap,
Expand Down
4 changes: 1 addition & 3 deletions embedchain/chunkers/pdf_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ class PdfFileChunker(BaseChunker):

def __init__(self, config: Optional[ChunkerConfig] = None):
if config is None:
config = ChunkerConfig(
chunk_size=1000, chunk_overlap=0, length_function=len
)
config = ChunkerConfig(chunk_size=1000, chunk_overlap=0, length_function=len)
text_splitter = RecursiveCharacterTextSplitter(
chunk_size=config.chunk_size,
chunk_overlap=config.chunk_overlap,
Expand Down
4 changes: 1 addition & 3 deletions embedchain/chunkers/youtube_video.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ class YoutubeVideoChunker(BaseChunker):

def __init__(self, config: Optional[ChunkerConfig] = None):
if config is None:
config = ChunkerConfig(
chunk_size=2000, chunk_overlap=0, length_function=len
)
config = ChunkerConfig(chunk_size=2000, chunk_overlap=0, length_function=len)
text_splitter = RecursiveCharacterTextSplitter(
chunk_size=config.chunk_size,
chunk_overlap=config.chunk_overlap,
Expand Down