don't add 16x on every render

mellbye · May 16, 2022 · d2c3cdc · d2c3cdc
1 parent 7c81421
commit d2c3cdc
Showing 1 changed file with 16 additions and 15 deletions.
diff --git a/web/src/components/VideoPlayer.jsx b/web/src/components/VideoPlayer.jsx
@@ -6,24 +6,25 @@ import 'videojs-seek-buttons';
 import 'video.js/dist/video-js.css';
 import 'videojs-seek-buttons/dist/videojs-seek-buttons.css';
 
-const defaultOptions = {
- controls: true,
- playbackRates: [0.5, 1, 2, 4, 8],
- fluid: true,
-};
-const defaultSeekOptions = {
- forward: 30,
- back: 10,
-};
-
 export default function VideoPlayer({ children, options, seekOptions = {}, onReady = () => {}, onDispose = () => {} }) {
  const playerRef = useRef();
-
- if (!videojs.browser.IS_FIREFOX) {
- defaultOptions.playbackRates.push(16);
- }
-
+
  useEffect(() => {
+ const defaultOptions = {
+ controls: true,
+ playbackRates: [0.5, 1, 2, 4, 8],
+ fluid: true,
+ };
+
+ const defaultSeekOptions = {
+ forward: 30,
+ back: 10,
+ };
+
+ if (!videojs.browser.IS_FIREFOX) {
+ defaultOptions.playbackRates.push(16);
+ }
+
  const player = videojs(playerRef.current, { ...defaultOptions, ...options }, () => {
  onReady(player);
  });