Add OpenAI tests #4846
Merged
Add OpenAI tests #4846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irevoire
approved these changes
Aug 5, 2024
Comment on lines
+112
to
+118
| let compressed_responses = include_bytes!("openai_tokenized_responses.json.gz"); | ||
| let mut responses = Vec::new(); | ||
| let mut decoder = flate2::write::GzDecoder::new(&mut responses); | ||
|
|
||
| decoder.write_all(compressed_responses).unwrap(); | ||
| drop(decoder); | ||
| serde_json::from_slice(&responses).unwrap() |
There was a problem hiding this comment.
We may consider putting an on-disk cache on this part if it starts taking a lot of time
Comment on lines
+1643
to
+1648
| // test with a server that responds 500 on 3 out of 4 calls | ||
| #[actix_rt::test] | ||
| async fn it_still_works() { | ||
| let (_mock, setting) = create_fallible_mock().await; | ||
| let server = get_server_vector().await; | ||
| let index = server.index("doggo"); |
There was a problem hiding this comment.
That's a very nice test tbh
It’s awesome you did it
meili-bors bot
added a commit
that referenced
this pull request
Aug 5, 2024
4846: Add OpenAI tests r=irevoire a=dureuill # Pull Request ## Related issue Part of fixing #4757 ## What does this PR do? - OpenAI embedder: don't pass apiKey when it is empty (slightly improves error messages) - rest embedder and rest-based embedders: specialize the authorization denied error message depending on the configuration source - fix existing tests - Adds assets containing prerecorded texts to embed and the embeddings obtained from OpenAI - Adds an asset containing a tokenized long document and the embedding obtained from OpenAI for this token - Uses the wiremock crate to mock the OpenAI API: parse the openai request, lookup the response in assets, craft an openai response Co-authored-by: Louis Dureuil <[email protected]>
|
Build failed: |
|
bors merge |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Part of fixing #4757
What does this PR do?