Add CS job (predis#1024)

* Add CS job

* Apply PHP71Migration ruleset

.github/workflows/coding-standards.yml

@@ -0,0 +1,28 @@
+name: Linters
+
+on:
+  push:
+    branches:
+      - main
+      - v2.**
+  pull_request:
+
+jobs:
+
+  php-cs-fixer:
+    name: linter
+    runs-on: ubuntu-latest
+
+    steps:
+
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Setup PHP with Composer and extensions
+        with:
+          php-version: 8.1
+          tools: php-cs-fixer
+        uses: shivammathur/setup-php@v2
+
+      - name: Run php-cs-fixer
+        run: php-cs-fixer fix --diff --dry-run --allow-risky=yes --using-cache=no

.php-cs-fixer.dist.php

@@ -13,6 +13,7 @@
 return (new PhpCsFixer\Config)
     ->setUsingCache(false)
     ->setRules([
+        '@PHP71Migration' => true,
         'header_comment' => ['header' => $PREDIS_HEADER],
         '@Symfony' => true,
         'phpdoc_separation' => false,

examples/custom_cluster_distributor.php

@@ -54,7 +54,7 @@ public function getSlot($hash)
 
     public function getBySlot($slot)
     {
-        return isset($this->nodes[$slot]) ? $this->nodes[$slot] : null;
+        return $this->nodes[$slot] ?? null;
     }
 
     public function getByHash($hash)

examples/transaction_using_cas.php

@@ -36,7 +36,7 @@ function zpop($client, $key)
     ];
 
     $client->transaction($options, function ($tx) use ($key, &$element) {
-        @list($element) = $tx->zrange($key, 0, 0);
+        @[$element] = $tx->zrange($key, 0, 0);
 
         if (isset($element)) {
             $tx->multi();   // With CAS, MULTI *must* be explicitly invoked.

src/Collection/Iterator/CursorBasedIterator.php

@@ -118,7 +118,7 @@ abstract protected function executeCommand();
      */
     protected function fetch()
     {
-        list($cursor, $elements) = $this->executeCommand();
+        [$cursor, $elements] = $this->executeCommand();
 
         if (!$cursor) {
             $this->fetchmore = false;

src/Command/Redis/BITOP.php

@@ -33,7 +33,7 @@ public function getId()
     public function setArguments(array $arguments)
     {
         if (count($arguments) === 3 && is_array($arguments[2])) {
-            list($operation, $destination) = $arguments;
+            [$operation, $destination] = $arguments;
             $arguments = $arguments[2];
             array_unshift($arguments, $operation, $destination);
         }

src/Command/Redis/BLPOP.php

@@ -33,7 +33,7 @@ public function getId()
     public function setArguments(array $arguments)
     {
         if (count($arguments) === 2 && is_array($arguments[0])) {
-            list($arguments, $timeout) = $arguments;
+            [$arguments, $timeout] = $arguments;
             array_push($arguments, $timeout);
         }
 

src/Command/Redis/BRPOP.php

@@ -33,7 +33,7 @@ public function getId()
     public function setArguments(array $arguments)
     {
         if (count($arguments) === 2 && is_array($arguments[0])) {
-            list($arguments, $timeout) = $arguments;
+            [$arguments, $timeout] = $arguments;
             array_push($arguments, $timeout);
         }
 

src/Command/Redis/CLIENT.php

@@ -63,7 +63,7 @@ protected function parseClientList($data)
             $client = [];
 
             foreach (explode(' ', $clientData) as $kv) {
-                @list($k, $v) = explode('=', $kv);
+                @[$k, $v] = explode('=', $kv);
                 $client[$k] = $v;
             }
 

src/Command/Redis/INFO.php

@@ -62,7 +62,7 @@ public function parseNewResponseFormat($lines)
                 continue;
             }
 
-            list($k, $v) = $this->parseRow($row);
+            [$k, $v] = $this->parseRow($row);
             $current[$k] = $v;
         }
 
@@ -81,7 +81,7 @@ public function parseOldResponseFormat($lines)
                 continue;
             }
 
-            list($k, $v) = $this->parseRow($row);
+            [$k, $v] = $this->parseRow($row);
             $info[$k] = $v;
         }
 
@@ -97,7 +97,7 @@ public function parseOldResponseFormat($lines)
      */
     protected function parseRow($row)
     {
-        list($k, $v) = explode(':', $row, 2);
+        [$k, $v] = explode(':', $row, 2);
 
         if (preg_match('/^db\d+$/', $k)) {
             $v = $this->parseDatabaseStats($v);
@@ -118,7 +118,7 @@ protected function parseDatabaseStats($str)
         $db = [];
 
         foreach (explode(',', $str) as $dbvar) {
-            list($dbvk, $dbvv) = explode('=', $dbvar);
+            [$dbvk, $dbvv] = explode('=', $dbvar);
             $db[trim($dbvk)] = $dbvv;
         }
 

src/Command/Redis/ZRANGEBYLEX.php

@@ -37,8 +37,8 @@ protected function prepareOptions($options)
             $limit = array_change_key_case($opts['LIMIT'], CASE_UPPER);
 
             $finalizedOpts[] = 'LIMIT';
-            $finalizedOpts[] = isset($limit['OFFSET']) ? $limit['OFFSET'] : $limit[0];
-            $finalizedOpts[] = isset($limit['COUNT']) ? $limit['COUNT'] : $limit[1];
+            $finalizedOpts[] = $limit['OFFSET'] ?? $limit[0];
+            $finalizedOpts[] = $limit['COUNT'] ?? $limit[1];
         }
 
         return $finalizedOpts;

src/Command/Redis/ZRANGEBYSCORE.php

@@ -37,8 +37,8 @@ protected function prepareOptions($options)
             $limit = array_change_key_case($opts['LIMIT'], CASE_UPPER);
 
             $finalizedOpts[] = 'LIMIT';
-            $finalizedOpts[] = isset($limit['OFFSET']) ? $limit['OFFSET'] : $limit[0];
-            $finalizedOpts[] = isset($limit['COUNT']) ? $limit['COUNT'] : $limit[1];
+            $finalizedOpts[] = $limit['OFFSET'] ?? $limit[0];
+            $finalizedOpts[] = $limit['COUNT'] ?? $limit[1];
         }
 
         return array_merge($finalizedOpts, parent::prepareOptions($options));

src/Connection/Cluster/RedisCluster.php

@@ -285,7 +285,7 @@ public function askSlotMap(NodeConnectionInterface $connection = null)
         foreach ($response as $slots) {
             // We only support master servers for now, so we ignore subsequent
             // elements in the $slots array identifying slaves.
-            list($start, $end, $master) = $slots;
+            [$start, $end, $master] = $slots;
 
             if ($master[0] === '') {
                 $this->slotmap->setSlots($start, $end, (string) $connection);
@@ -461,7 +461,7 @@ protected function onErrorResponse(CommandInterface $command, ErrorResponseInter
      */
     protected function onMovedResponse(CommandInterface $command, $details)
     {
-        list($slot, $connectionID) = explode(' ', $details, 2);
+        [$slot, $connectionID] = explode(' ', $details, 2);
 
         if (!$connection = $this->getConnectionById($connectionID)) {
             $connection = $this->createConnection($connectionID);
@@ -487,7 +487,7 @@ protected function onMovedResponse(CommandInterface $command, $details)
      */
     protected function onAskResponse(CommandInterface $command, $details)
     {
-        list($slot, $connectionID) = explode(' ', $details, 2);
+        [$slot, $connectionID] = explode(' ', $details, 2);
 
         if (!$connection = $this->getConnectionById($connectionID)) {
             $connection = $this->createConnection($connectionID);

src/Connection/Replication/MasterSlaveReplication.php

@@ -375,7 +375,7 @@ private function handleInfoResponse($response)
                 continue;
             }
 
-            list($k, $v) = explode(':', $row, 2);
+            [$k, $v] = explode(':', $row, 2);
             $info[$k] = $v;
         }
 

src/Monitor/Consumer.php

@@ -166,7 +166,7 @@ private function getValue()
         };
 
         $event = preg_replace_callback('/ \(db (\d+)\) | \[(\d+) (.*?)\] /', $callback, $event, 1);
-        @list($timestamp, $command, $arguments) = explode(' ', $event, 3);
+        @[$timestamp, $command, $arguments] = explode(' ', $event, 3);
 
         return (object) [
             'timestamp' => (float) $timestamp,

src/Response/Error.php

@@ -41,7 +41,7 @@ public function getMessage()
      */
     public function getErrorType()
     {
-        list($errorType) = explode(' ', $this->getMessage(), 2);
+        [$errorType] = explode(' ', $this->getMessage(), 2);
 
         return $errorType;
     }

src/Response/ServerException.php

@@ -26,7 +26,7 @@ class ServerException extends PredisException implements ErrorInterface
      */
     public function getErrorType()
     {
-        list($errorType) = explode(' ', $this->getMessage(), 2);
+        [$errorType] = explode(' ', $this->getMessage(), 2);
 
         return $errorType;
     }

tests/PHPUnit/PredisTestCase.php

@@ -75,7 +75,7 @@ public function isRedisCommand($command = null, ?array $arguments = null): Redis
     public function assertRedisCommand($expected, $actual, string $message = ''): void
     {
         if (is_array($expected)) {
-            @list($command, $arguments) = $expected;
+            @[$command, $arguments] = $expected;
         } else {
             $command = $expected;
             $arguments = null;

tests/Predis/ClientTest.php

@@ -1268,9 +1268,9 @@ protected function getParametersString(array $parameters): string
     {
         $defaults = $this->getDefaultParametersArray();
 
-        $scheme = isset($parameters['scheme']) ? $parameters['scheme'] : $defaults['scheme'];
-        $host = isset($parameters['host']) ? $parameters['host'] : $defaults['host'];
-        $port = isset($parameters['port']) ? $parameters['port'] : $defaults['port'];
+        $scheme = $parameters['scheme'] ?? $defaults['scheme'];
+        $host = $parameters['host'] ?? $defaults['host'];
+        $port = $parameters['port'] ?? $defaults['port'];
 
         unset($parameters['scheme'], $parameters['host'], $parameters['port']);
         $uriString = "$scheme:https://$host:$port/?";

tests/Predis/Cluster/Distributor/KetamaRingTest.php

@@ -29,7 +29,7 @@ public function testHash(): void
     {
         /** @var HashGeneratorInterface */
         $ring = $this->getDistributorInstance();
-        list(, $hash) = unpack('V', md5('foobar', true));
+        [, $hash] = unpack('V', md5('foobar', true));
 
         $this->assertEquals($hash, $ring->hash('foobar'));
     }

tests/Predis/Command/Redis/INFO_Test.php

@@ -310,7 +310,7 @@ public function testReturnsAnArrayOfInfo(): void
         $command = $this->getCommand();
 
         $this->assertIsArray($info = $redis->executeCommand($command));
-        $this->assertArrayHasKey('redis_version', isset($info['Server']) ? $info['Server'] : $info);
+        $this->assertArrayHasKey('redis_version', $info['Server'] ?? $info);
     }
 
     /**

tests/Predis/Command/Redis/SETRANGE_Test.php

@@ -98,7 +98,7 @@ public function testHandlesBinaryData(): void
 
         $this->assertSame(4, $redis->setrange('key:binary', 0, pack('i', -2147483648)));
 
-        list($unpacked) = array_values(unpack('i', $redis->get('key:binary')));
+        [$unpacked] = array_values(unpack('i', $redis->get('key:binary')));
         $this->assertEquals(-2147483648, $unpacked);
     }
 

tests/Predis/Command/Redis/UNSUBSCRIBE_Test.php

@@ -121,8 +121,8 @@ public function testUnsubscribesFromAllSubscribedChannels(): void
         $this->assertSame(['subscribe', 'channel:foo', 1], $redis->subscribe('channel:foo'));
         $this->assertSame(['subscribe', 'channel:bar', 2], $redis->subscribe('channel:bar'));
 
-        list($_, $unsubscribed1, $_) = $redis->unsubscribe();
-        list($_, $unsubscribed2, $_) = $redis->getConnection()->read();
+        [$_, $unsubscribed1, $_] = $redis->unsubscribe();
+        [$_, $unsubscribed2, $_] = $redis->getConnection()->read();
         $this->assertSameValues(['channel:foo', 'channel:bar'], [$unsubscribed1, $unsubscribed2]);
 
         $this->assertSame('echoed', $redis->echo('echoed'));

tests/Predis/Configuration/Option/AggregateTest.php

@@ -260,7 +260,7 @@ public function testThrowsExceptionOnInstanceOfAggregateConnectionInterface(): v
      */
     public function ___AggregateConnectionSkipCreationOnConnectionInstance(): void
     {
-        list(, $connectionClass) = $this->getMockConnectionClass();
+        [, $connectionClass] = $this->getMockConnectionClass();
 
         /** @var ClusterInterface|MockObject */
         $cluster = $this->getMockBuilder('Predis\Connection\Cluster\ClusterInterface')->getMock();
@@ -285,7 +285,7 @@ public function ___AggregateConnectionSkipCreationOnConnectionInstance(): void
      */
     public function ___AggregateConnectionWithMixedParameters(): void
     {
-        list(, $connectionClass) = $this->getMockConnectionClass();
+        [, $connectionClass] = $this->getMockConnectionClass();
 
         /** @var ClusterInterface|MockObject */
         $cluster = $this->getMockBuilder('Predis\Connection\Cluster\ClusterInterface')->getMock();

tests/Predis/Connection/FactoryTest.php

@@ -439,7 +439,7 @@ public function testCreateUndefinedConnection(): void
      */
     public function testDefineConnectionWithFQN(): void
     {
-        list(, $connectionClass) = $this->getMockConnectionClass();
+        [, $connectionClass] = $this->getMockConnectionClass();
 
         $parameters = new Parameters(['scheme' => 'foobar']);
         $factory = new Factory();
@@ -455,7 +455,7 @@ public function testDefineConnectionWithFQN(): void
      */
     public function testDefineConnectionWithCallable(): void
     {
-        list(, $connectionClass) = $this->getMockConnectionClass();
+        [, $connectionClass] = $this->getMockConnectionClass();
 
         $parameters = new Parameters(['scheme' => 'foobar']);
         $factory = new Factory();
@@ -527,7 +527,7 @@ public function testDefineAndUndefineConnection(): void
         $this->expectException('InvalidArgumentException');
         $this->expectExceptionMessage("Unknown connection scheme: 'test'");
 
-        list(, $connectionClass) = $this->getMockConnectionClass();
+        [, $connectionClass] = $this->getMockConnectionClass();
 
         $factory = new Factory();
 

tests/Predis/Connection/ParametersTest.php

@@ -415,9 +415,9 @@ protected function getParametersString(array $parameters): string
     {
         $defaults = $this->getDefaultParametersArray();
 
-        $scheme = isset($parameters['scheme']) ? $parameters['scheme'] : $defaults['scheme'];
-        $host = isset($parameters['host']) ? $parameters['host'] : $defaults['host'];
-        $port = isset($parameters['port']) ? $parameters['port'] : $defaults['port'];
+        $scheme = $parameters['scheme'] ?? $defaults['scheme'];
+        $host = $parameters['host'] ?? $defaults['host'];
+        $port = $parameters['port'] ?? $defaults['port'];
 
         unset($parameters['scheme'], $parameters['host'], $parameters['port']);
         $uriString = "$scheme:https://$host:$port/?";

tests/Predis/Connection/Replication/MasterSlaveReplicationTest.php

@@ -989,7 +989,7 @@ public function testAcceptsCallableToOverrideReadOnlyFlagForCommands(): void
         $replication
             ->getReplicationStrategy()
             ->setCommandReadOnly('exists', function ($cmd) {
-                list($arg1) = $cmd->getArguments();
+                [$arg1] = $cmd->getArguments();
 
                 return $arg1 === 'foo';
             });

tests/Predis/Pipeline/PipelineTest.php

@@ -541,7 +541,7 @@ protected function getReadCallback(): callable
                 throw new InvalidArgumentException("Expected ECHO, got {$id}");
             }
 
-            list($echoed) = $command->getArguments();
+            [$echoed] = $command->getArguments();
 
             return $echoed;
         };

tests/Predis/Transaction/MultiExecTest.php

@@ -940,7 +940,7 @@ protected function getExecuteCallback(
                     return true;
 
                 case 'ECHO':
-                    @list($trigger) = $command->getArguments();
+                    @[$trigger] = $command->getArguments();
                     if (strpos($trigger, 'ERR ') === 0) {
                         throw new Response\ServerException($trigger);
                     }