chore: Update dependencies (Cargo.toml
)
#478
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistently omit patch version.
Package notes:
lazy_static
to1.4
(note that this crate is deprecated officially, in favor ofonce_cell
).warp
:=
in Nov 2021 due to concern with MSRVwarp
maintainer.warp
MSRV was 1.51 at the time, which is also when "const generics" feature was introduced (March 2021).serde
andlazy_static
were repeated indev-dependencies
for some reason in Dec 2021. That also addednotify
with the^
qualifier, but this is the implicit default and stripped away from dependencies in this project some time ago.Outdated (not likely helpful)
UPDATE: This information may not be that useful to anyone else, hence the collapsed section. It's mostly been superseded by what I learned when preparing #495
Other MSRV history since the March 2022
warp
reference:config-rs
documented a version bump of MSRV from 1.49 to 1.56 (Nov 2021).config-rs
bumped MSRV from 1.60 to 1.64 (Sep 2022) due to dev-dependencytemp-env
.config-rs
bumped MSRV again to 1.66 (Dec 2022), with no documented reason for the requirement this time.You may want to update
Cargo.toml
to communicate MSRV better viarust-version
.rust-version
. At the very least, the real MSRV required for published crate should be identified, perhaps viacargo-msrv
?AFAIK, the patch versions have been set often without bumping, and without any actual requirement to make that the minimum patch version. So they are not actually serving much purpose.
Initially I misunderstood these to implicitly be
=
(fixed), hence the original motivation of the PR. As that's not the case, this does raiselazy_static
to1.4
as a minimum, which could be reverted.lazy_static
last released1.4
in Aug 2019, so I don't consider that a concern.EDIT:
major.minor
semver dependency of their own, and that dependency later pushing out a point release with a feature only stabilized since Rust1.71
(July 2023), which leaked through toconfig-rs
CI catching the failure (but could just as easily slipped through like forrust-ini
if the timing was a little later with theordered-multimap
crate patch release? 🤷♂️ )ahash
too (upstream issue), but since resolved.Additionally, the(EDIT:version
field is set to0.13.1
, while crates reports0.13.3
?0.13.x
is maintained via a separate branch, related PR raised)Another possible update is the
edition
to 2021 🤷♂️