Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added autocomplete-module-import #54

Merged
merged 1 commit into from
Jul 5, 2017
Merged

Conversation

Shipow
Copy link
Contributor

@Shipow Shipow commented Jun 26, 2017

autocomplete-module-import
Search & install npm packages from import/require statements

@mehcode
Copy link
Owner

mehcode commented Jul 5, 2017

@Shipow This is pretty cool.

If I were you I'd ask/beg/cajole https://github.com/spacegeek224/autocomplete-npm or atom devs if @spacegeek224 is unresponsive as that would be a much, much better name. Heck I'd even rename your package to autocomplete-npm-plus if all else fails.

I haven't tested it but I'd also work with https://atom.io/packages/autocomplete-modules to make sure your suggestions have less priority.

I won't ask you to do it in this PR but we do need an Autocomplete section if you want to set that up.

@mehcode mehcode merged commit 255f906 into mehcode:master Jul 5, 2017
@Shipow
Copy link
Contributor Author

Shipow commented Jul 5, 2017

Hey thanks, these are nice suggestions. We'll see what we can do. I'll keep you posted.

@FlorianWendelborn
Copy link
Contributor

FYI the link is a 404. atom- should be removed. @Shipow @mehcode

@mehcode
Copy link
Owner

mehcode commented Jul 7, 2017

Hah. I guess that's what happens when I ignore the issue to add CI to this. Thanks for letting us know. Could you fix that @Shipow ?

@marisusis
Copy link

I was mentioned here, I haven't checked notifications for a while, is there anything I can do about the apm package?

@mehcode
Copy link
Owner

mehcode commented Oct 24, 2017

👋 @spacegeek224 I actually don't know. I think the only way to transfer ownership of a name is to transfer the repository itself.

So steps for that would be:

1 - @spacegeek224 recreates https://github.com/spacegeek224/autocomplete-npm (yes I believe this step is necessary)
2 - @spacegeek224 transfers the repository to @Shipow

@marisusis
Copy link

marisusis commented Oct 24, 2017

Sure!
Sorry I didn't see this earlier, I initially wanted to make my own autocomplete package, but then forgot about it.
I'd love to see a function npm autocomplete module in Atom!

@proudlygeek
Copy link

Hello everyone 👋

I worked together with @Shipow on the autocomplete plugin, it would be really awesome to do this 👍

@spacegeek224, could you transfer the repository to me (@proudlygeek) instead? 👼

Thanks!

@marisusis
Copy link

marisusis commented Oct 26, 2017 via email

@Shipow
Copy link
Contributor Author

Shipow commented Oct 27, 2017

@spacegeek224 Well I'm sorry but I missed the notification /o\

image

Would you do it again?
Thx \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants