Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http getsize and getmtime #95

Merged
merged 10 commits into from
Nov 25, 2021
Merged

Http getsize and getmtime #95

merged 10 commits into from
Nov 25, 2021

Conversation

LoveEatCandy
Copy link
Collaborator

#94

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2021

Codecov Report

Merging #95 (2d6565e) into main (1e1bf26) will decrease coverage by 0.09%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   90.75%   90.66%   -0.10%     
==========================================
  Files          33       33              
  Lines        3666     3694      +28     
==========================================
+ Hits         3327     3349      +22     
- Misses        339      345       +6     
Impacted Files Coverage Δ
megfile/http_path.py 82.35% <66.66%> (-9.96%) ⬇️
megfile/http.py 79.31% <89.47%> (+4.31%) ⬆️
megfile/errors.py 85.31% <100.00%> (ø)
megfile/s3.py 91.13% <0.00%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e1bf26...2d6565e. Read the comment docs.

@bbtfr
Copy link
Collaborator

bbtfr commented Nov 24, 2021

实现一个 http_stat,其它是它的 alias

@bbtfr
Copy link
Collaborator

bbtfr commented Nov 25, 2021

👍

megfile/http.py Outdated
time.strptime(last_modified, "%a, %d %b %Y %H:%M:%S %Z"))

content_type = response.headers.get('Content-Type')
_logger.info("http response Content-Type: %s" % content_type)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是啥?

@LoveEatCandy LoveEatCandy merged commit 6f618e1 into megvii-research:main Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants