Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes and updates #80

Merged
merged 32 commits into from
Jul 13, 2023
Merged

Misc fixes and updates #80

merged 32 commits into from
Jul 13, 2023

Conversation

meghdadFar
Copy link
Owner

  • Improve docstring in various places.
  • Allow plot configuration via **kwargs in text and label plots.
  • Change cove.
  • Improve plot reconfigurability.

@meghdadFar meghdadFar requested a review from leobeeson July 7, 2023 12:12
@leobeeson
Copy link
Collaborator

Perhaps of minor importance, but updating/installing new dependencies via poetry is generating several errors, primarily:

Installing dependencies from lock file

Package operations: 54 installs, 21 updates, 0 removals

  • Updating platformdirs (3.5.1 -> 3.8.0): Failed

  AttributeError

  'HTTPResponse' object has no attribute 'strict'

  at .venv/lib/python3.10/site-packages/cachecontrol/serialize.py:54 in dumps
       50│                 ),
       51│                 u"status": response.status,
       52│                 u"version": response.version,
       53│                 u"reason": text_type(response.reason),
    →  54│                 u"strict": response.strict,
       55│                 u"decode_content": response.decode_content,
       56│             }
       57│         }
       58│ 

I've managed to get the project dependencies updated manually via pip install <PACKAGE> and get the code to run. Looking online it says it might be a compatibility problem with Python 3.10, but since I've managed to manually install the dependencies, it might be a problem with poetry (as usual :D).

Copy link
Collaborator

@leobeeson leobeeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments on demo notebook.

@meghdadFar
Copy link
Owner Author

@leobeeson Thanks for your review.
I pushed some fixes and otherwise added comments. Please see above.
For the poetry error, I created issue #81.
I don't even know WTF is platformdirs and who requires it.
Anyways, we can look closer into it in another PR.

@meghdadFar meghdadFar merged commit 608962a into main Jul 13, 2023
3 checks passed
@meghdadFar meghdadFar deleted the meghdadFar/misc-fixes-updates branch July 13, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants