Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove refresh time calculation from probe, and add the refresh parameter in URL #94

Merged
merged 1 commit into from
May 18, 2022

Conversation

haoel
Copy link
Contributor

@haoel haoel commented May 18, 2022

  • remove the code that calculates the auto-refresh time from the probes.
  • Add the refresh parameter in URL - http:https://localhost:8181/?refersh=30s

fix issue #93

@haoel haoel requested a review from proditis May 18, 2022 00:49
Copy link
Collaborator

@proditis proditis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haoel haoel merged commit 115fdab into megaease:main May 18, 2022
@@ -208,7 +208,7 @@ Check the [Notification Configuration](#37-notification-configuration) to see h

The EaseProbe would listen on the `0.0.0.0:8181` port by default. And you can access the Live SLA report by the following URL:

- HTML: `http:https://localhost:8181/`
- HTML: `http:https://localhost:8181/` or `http:https://localhost:8181/?refersh=30s`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should refersh -> refresh ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, should be refresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants