-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix undefined processExists error #87
Conversation
This is a very good finding. I realize I made a mistake - the file
So, I think the correct fix as below
|
Just Google how to test it (article). we can run the following command to check how the cd daemon
GOOS=openbsd GOARCH=amd64 go list -f '{{.GoFiles}}' |
Linux is not a good candidate for BSD systems since these have no I see two options
What do you think? |
I like the 2nd one, as darwin is based on the BSD system. And don't forget to remove the go-build tags in |
also update the build contraints
The list of files each os pulls
|
daemon/daemon_unix.go
Outdated
//go:build darwin || openbsd | ||
// +build darwin openbsd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about adding freebsd and netbsd?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️ How could i ever ?!?!?! 😄 adding the rest of the family
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think if we make this our fall back for unix systems and simply exclude linux/windows on top ?
There are a lot more unix systems that will work with this one rather with the linux.
!linux && !windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the !linux && !windows
file without a problem
now we support more platforms out of the box
Wonderful! @proditis |
just a copy of daemon_darwin to fix daemon/daemon.go:90:5: undefined: processExists
I tried changing the headers to make the daemon_darwin be used but it kept failing.
Is this command i'm using to cross-compile easeprobe wrong?