Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug-fixing: mkdir error when the SLA data file is not specified the path #85

Merged
merged 2 commits into from
May 15, 2022
Merged

bug-fixing: mkdir error when the SLA data file is not specified the path #85

merged 2 commits into from
May 15, 2022

Conversation

haoel
Copy link
Contributor

@haoel haoel commented May 15, 2022 •
edited
Loading

If the configuration is:

settings:
   sla:
        data: data.yaml

The EaseProbe would raise an error

Failed to save the SLA data to file: mkdir : no such file or directory

Because the dir string we pass to os.MkdirAll(dir, 0755) is empty.

this is a fix for this bug.

@haoel haoel merged commit 8a50d76 into megaease:main May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@proditis proditis proditis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@haoel @proditis